We're going to remove a couple of items in the refactor theming patch into their own patches.

This one is regarding the seek functionality. The patch moves jw_player_seek.js into the new js subdirectory, and renames the file as "jw_player.seek.js" to be consistent with similar files.

I will post the patch in a few minutes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ron_s created an issue. See original summary.

ron_s’s picture

Status: Active » Needs review
FileSize
2.13 KB

See attached, thanks.

Berdir’s picture

Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Patch is small enough, but note that your git client is still not properly set up for renames. This is what I see when I do a git diff:

diff --git a/jw_player_seek.js b/js/jw_player.seek.js
similarity index 100%
rename from jw_player_seek.js
rename to js/jw_player.seek.js
diff --git a/jw_player.module b/jw_player.module
index 946d345..2ade65b 100644
--- a/jw_player.module
+++ b/jw_player.module
@@ -820,7 +820,7 @@ function jw_player_libraries_info() {
       ),
       'integration files' => array(
         'jw_player' => array(
-          'js' => array('jw_player_seek.js')
+          'js' => array('js/jw_player.seek.js')
         ),
       ),
       'callbacks' => array(

  • Berdir committed c65ac14 on 7.x-2.x authored by ron_s
    Issue #2719851 by ron_s: Move seek js file
    
ron_s’s picture

Sorry about that, I think it's because the file was directly moved rather than using git mv.

johnchque’s picture

Is this seek file ever used in d8 version of the module?

ron_s’s picture

@yongt9412, I think it should be, and also needs to be coordinated with this patch: https://www.drupal.org/node/1894656