Problem/Motivation

class EntityCollectionStyleHierarchyLimited method build() is using an arbitrary expression which was introduced in PHP 5.5. Therefore the plugin lacks PHP 5.4 support.

if ( !empty($limitation = $this->getLimits()) ) {}

I know that PHP 5.4 is for long time EOL, but I think for Drupal 7 modules it needs to be considered till it's own end of life, as there are too much running PHP 5.4 environments in the world.

Proposed resolution

Save the result in the variable first and and then process the empty check.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

szeidler created an issue. See original summary.

szeidler’s picture

szeidler’s picture

Status: Active » Needs review
esolitos’s picture

Status: Needs review » Reviewed & tested by the community

To be committed!

  • esolitos committed bbaafeb on 7.x-2.x authored by szeidler
    Issue #2719393 by szeidler: Plugin "Hierarchy Limited Style" msut be...
esolitos’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.