if ($file_entity = FileType::load($value)) {
      return $file_entity->label();
    }

FileType::load() gets you a file type entity, not a file entity.

CommentFileSizeAuthor
#5 file_entity-confuse-variable-name-2718173-5.patch548 bytesrashid_786
#2 file_entity-confusing-variable-name-2718173-2.patch562 bytesrashid_786
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

rashid_786’s picture

rashid_786 CreditAttribution: rashid_786 at SDG Corporation commented
Status: Active » Needs review
FileSize
file_entity-confusing-variable-name-2718173-2.patch562 bytes

patch created with necessary changes.

Status: Needs review » Needs work

The last submitted patch, 2: file_entity-confusing-variable-name-2718173-2.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Test fail is unrelated.

If we change it anyway, lets use just $file_type. the entity suffix is not necessary.

rashid_786’s picture

rashid_786 CreditAttribution: rashid_786 at SDG Corporation commented
Status: Needs work » Needs review
FileSize
file_entity-confuse-variable-name-2718173-5.patch548 bytes

Changes made as suggested.

Status: Needs review » Needs work

The last submitted patch, 5: file_entity-confuse-variable-name-2718173-5.patch, failed testing.

The last submitted patch, 5: file_entity-confuse-variable-name-2718173-5.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community

Thanks.

rashid_786’s picture

rashid_786 CreditAttribution: rashid_786 at SDG Corporation commented