Problem/Motivation

RevisionControllerTrait doesn't properly generate the operations links render array. Furthermore RevisionOverviewController::buildRevertRevisionLink() checks for a non-existent link template.

Proposed resolution

Check for "revision-revert-form" (and "revision-delete-form") link templates in RevisionOverviewController::buildRevertRevisionLink() and format them as "operations" links in RevisionControllerTrait::revisionOverview().

CommentFileSizeAuthor
#2 revisioncontrollertrait-2717937-2.patch3 KBparanojik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paranojik created an issue. See original summary.

paranojik’s picture

paranojik CreditAttribution: paranojik as a volunteer commented
Status: Active » Needs review
FileSize
revisioncontrollertrait-2717937-2.patch3 KB

Fix and test for the above.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. #2716139: Depend on Entity API to provide revision UI depends on it.

  • dawehner committed 68d3116 on 8.x-1.x authored by paranojik 
    Issue #2717937 by paranojik: RevisionControllerTrait doesn't properly...

  • dawehner committed 68d3116 on 8.x-2.x authored by paranojik 
    Issue #2717937 by paranojik: RevisionControllerTrait doesn't properly...
  • dawehner committed ebc11c7 on 8.x-2.x authored by paranojik
    Issue #2717937 by paranojik: RevisionControllerTrait doesn't properly...
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Works for me, we add test coverage and fix the bug. Thank you for providing the test!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 2: revisioncontrollertrait-2717937-2.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Closed (fixed)

Too late testbot.