The TruncateHTML class has properties which are unnecessarily public and methods which are unnecessarily private. Let's just make everything protected. That means anything that extends the class has access - which seems nice in an open source world - but it's internal variables are not exposed.

CommentFileSizeAuthor
#2 2717471-2.patch2.45 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2717471-2.patch2.45 KB

  • markie committed 1cdd9a3 on 8.x-1.x authored by alexpott 
    Issue #2717471 by alexpott: TruncateHTML has weird scope declarations
markie’s picture

markie CreditAttribution: markie at Mediacurrent commented
Status: Needs review » Fixed

Patch looks good and tested. Went ahead and committed. Thanks for taking care of this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.