Current implementation reverts feature modules without checking if there are overriden or missing items.

CommentFileSizeAuthor
#6 features-import-all-overriden-and-missing-2717371-2.patch1.41 KBvolkerk
#4 features-import-all-overriden-and-missing-2717371.patch1.48 KBvolkerk
#2 features-import-all-overriden-and-hidden-2717371.patch1.48 KBvolkerk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

volkerk created an issue. See original summary.

volkerk’s picture

volkerk CreditAttribution: volkerk commented
FileSize
features-import-all-overriden-and-hidden-2717371.patch1.48 KB
volkerk’s picture

volkerk CreditAttribution: volkerk commented
Issue summary: View changes
volkerk’s picture

volkerk CreditAttribution: volkerk commented
FileSize
features-import-all-overriden-and-missing-2717371.patch1.48 KB
mpotter’s picture

mpotter CreditAttribution: mpotter at Phase2 commented
Status: Active » Needs work 
+++ b/drush/features.drush.inc
@@ -258,27 +258,29 @@ function drush_features_list_packages($package_name = '') {
+  foreach ($packages as $item) {

Try to avoid making un-needed changes. foreach loop should still use $package instead of $item.

Also, I'd like to see some reporting of which features were actually imported.

volkerk’s picture

volkerk CreditAttribution: volkerk commented
Status: Needs work » Needs review
FileSize
features-import-all-overriden-and-missing-2717371-2.patch1.41 KB

Since I am only passing a list of overridden packages to drush_features_import(), reporting of actions concerning and/or the state of these packages is already done via drush_log calls there. Additional reporting here would be redundant.

  • mpotter committed 643324b on 8.x-3.x authored by volkerk 
    Issue #2717371 by volkerk: Revert only if overidden or missing in...
mpotter’s picture

mpotter CreditAttribution: mpotter at Phase2 commented
Status: Needs review » Fixed

Committed to 643324b.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.