Long duplicate text if no paragraph present

1. +++ b/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
   @@ -730,7 +730,12 @@ class InlineParagraphsWidget extends WidgetBase {
   +        $add_text = 'No @title_multiple have been added yet. Press the button below to add one.';
   ...
   +        $add_text = 'No @title_multiple have been added yet. Select a @title type and press the button below to add one.';
   ...
          $element_text = '<p><em>' . t($add_text, array('@title_multiple' => $this->getSetting('title_plural'), '@title' => $this->getSetting('title'))) . '</em></p>';
   

   We want to avoid this. Static text should be on the same line like t() to allow parsing / extraction of translatables.

2. +++ b/src/Tests/ParagraphsAdministrationTest.php
   @@ -440,6 +440,21 @@ class ParagraphsAdministrationTest extends WebTestBase {
   +    $this->assertRaw('No Paragraphs have been added yet. Select a Paragraph type and press the button below to add one.');
   

   Also you assume that the multiple title is used here while IMHO english currently even wrong twice (should be "No Paragraph has been...").
   Not sure about proper single / multiple handling, but for instance Drupal also offers a language specific plural formula for translatables.

+++ b/src/Tests/ParagraphsAdministrationTest.php
@@ -440,6 +440,21 @@ class ParagraphsAdministrationTest extends WebTestBase {
+    $this->assertRaw('No Paragraph has been added yet. Select a Paragraph type and press the button below to add one.');
...
+    $this->assertRaw('No Paragraph has been added yet. Press the button below to add one.');

You can use assertText() instead of assertRaw() (use this when you want to assert HTML).

And would be nice if you write a comment about what you did in the uploading patch ;)

+++ b/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
@@ -730,8 +730,12 @@ class InlineParagraphsWidget extends WidgetBase {
+        $element_text = '<p><em>' . t('No @title has been added yet. Press the button below to add one.', array('@title' => $this->getSetting('title'))) . '</em></p>';
...
+        $element_text = '<p><em>' . t('No @title has been added yet. Select a @title type and press the button below to add one.', array('@title' => $this->getSetting('title'))) . '</em></p>';

and try to use [] instead of array() whenever you can/provide a patch (see array standard coding). Sorry for being annoying with these standard coding stuff ^^'

Nice! Looks good to me! :)

Not so sure about dropping this _multiple thing although it was unused...

What direction is core heading here? Berdir recently mentioned that Core tries to add multiple support for type labels.

Following the concept of empty messages like views, we want to keep them, but short.

The current text is long, duplicate to the button that is self explaining, and adds more confusion, because it's even wront (referring to the select + button case, not considering the button type setting).

Thus, we want to drop the second part of the text completely making it much reduced and clean.

Patch also needed to be re-rolled. Tests are currently failing, so leaving to "Needs Work" for now.

The test is deleting paragraph types which newly added tests were using, so I moved the test at the end of the test function. Should pass now.

Rescoping the issue summary.

Here we go.

Committed! :-)