For writing tests, etc, it would be easier to not have fields changing names. On the "Add filed" form, if there are existing fields, two forms on the same page are trying to use 'field_name'. It's fine for FAPI, but makes it harder to write tests, since the ID to post to will change depending on the # of existing fields, and the fields already added to the given content type.

Attached patch is trivial and tested.

CommentFileSizeAuthor
non-duplicate-keys.patch1.1 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KarenS’s picture

Status: Reviewed & tested by the community » Fixed

Looks like it should create no problems. I agree the one to change is the existing field name since I'm pretty sure there is no one using form_alter on that value, while there are modules expecting the field_name value in the add new field part. Committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.