Problem/Motivation

The NodeFlagType plugin class provides an internationalization option. This option is an artifact from the 7.x version of the module and is not used anywhere.

Proposed resolution

Remove the option completely. UI that doesn't work is worse than missing UI -- one gives the illusion that a feature is there, the other can prompt a user to file an issue.

Remaining tasks

Create patch.

User interface changes

The i18n option for node flag types would be removed.

API changes

There would be no i18n field in the plugin options.

Data model changes

There would be no i18n field in the plugin options.

CommentFileSizeAuthor
#2 deleteNodeTypei18n_2716601.2.patch2.38 KBsocketwench
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

socketwench created an issue. See original summary.

socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Active » Needs review
FileSize
deleteNodeTypei18n_2716601.2.patch2.38 KB
martin107’s picture

martin107 CreditAttribution: martin107 commented
Status: Needs review » Reviewed & tested by the community

Yep , that does look redundant.

  • socketwench committed 47579ef on 8.x-4.x 
    Issue #2716601 by socketwench: Removed useless i18n option in...
socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review, Martin!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.