Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
We have a user paragraph type in demo that is not working properly, it does not let you reference users and it has autocomplete set as off.
Proposed resolution
Fix it, add tests.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fix_user_paragraph_in-2716029-2.patch | 3.32 KB | johnchque |
| #2 | fix_user_paragraph_in-2716029-2-test-only.patch | 947 bytes | johnchque |
Comments
Comment #2
johnchqueThis makes it work as it should. :)
Comment #3
johnchqueComment #7
miro_dietikerThx, committed.
Comment #9
tduong CreditAttribution: tduong at MD Systems GmbH commentedNooo, was reviewing this patch... anyway, not sure if it is worth to extend the test checking also the cases for the authenticated and anonymous user (to check that the validation works also fine). And IMO the changes in core.entity_view_display.paragraph.user.default.yml are unrelated...
Comment #10
miro_dietikerNote that this is "just" a demo related test.
The demo test does not test if the paragraphs code works. The test only checks if the demo configuration results to a valid situation.
Thus testing if the validation works is IMHO not really a scope that makes sense here. There is for sure a test somewhere that makes sure the entity reference works nicely with a user target.
If you have some proposals to improve, just reopen the issue and provide a small follow-up diff.
Comment #11
tduong CreditAttribution: tduong at MD Systems GmbH commentedIMHO we should have a test each time we create a new feature. E.g. the "Nested Paragraphs" type first provided by the demo module, or to ensure that the links in the front page demo node work correctly (I'm not sure if they've worked before since there was no test for them). But I agree that probably that moment when we've created this module, it was already too much work at once, and as the current situation (hurry before the release) it's fine to just focus to other critical issues first :)