Problem/Motivation

Follow-up to #2543334: Auto-placeholdering for #lazy_builder with bubbling of contexts and tags

Marking the presence of a @todo in core/profiles/standard/src/Tests/StandardTest.php:

    // @todo uncomment after https://www.drupal.org/node/2543334 has landed.
    //url = Url::fromRoute('entity.node.canonical', ['node' => 1]);
    //$this->drupalGet($url);
    //$this->drupalGet($url);
    //$this->assertEqual('HIT', $this->drupalGetHeader(DynamicPageCacheSubscriber::HEADER), 'Full node page is cached by Dynamic Page Cache.');

#2543334: Auto-placeholdering for #lazy_builder with bubbling of contexts and tags has, in fact, landed, so therefore this @todo is out of date.

Proposed resolution

  • Decide what is needed.
  • Update this issue summary with explanation.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 todo-standard-test-2715507-2.patch1.17 KBdagmar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Active » Needs review
FileSize
todo-standard-test-2715507-2.patch1.17 KB

Well, here is the patch for that. Tests pass locally.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Component: profile.module » install system
Status: Needs review » Reviewed & tested by the community

Nice one. The code is basically identical to the user case ...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 13f1c69 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 8f2c053 on 8.2.x 
    Issue #2715507 by dagmar: @todo: Modify core/profiles/standard/src/Tests...

  • alexpott committed 13f1c69 on 8.1.x 
    Issue #2715507 by dagmar: @todo: Modify core/profiles/standard/src/Tests...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.