Currently the module assumes that you will be sending the API key as a URL / GET parameter. We would prefer to set it as a header. The patch that follows allows you to pick one of three options. GET, POST and HTTP Header.

CommentFileSizeAuthor
#7 interdiff-2715419-5-7.txt1.01 KBBR0kEN
#7 services_api_key_auth-http_header_api_key-2715419-7.patch2.41 KBBR0kEN
#5 interdiff-2715419-4-5.txt1.75 KBBR0kEN
#5 services_api_key_auth-http_header_api_key-2715419-5.patch2.04 KBBR0kEN
#4 interdiff-2715419-1-4.txt2.36 KBBR0kEN
#4 services_api_key_auth-http_header_api_key-2715419-4.patch2 KBBR0kEN
#2 parameter_types-2715419-1.patch1.89 KBronald_istos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ronald_istos created an issue. See original summary.

ronald_istos’s picture

ronald_istos CreditAttribution: ronald_istos at roomify - online and open source reservation solutions commented
Status: Active » Needs review
FileSize
parameter_types-2715419-1.patch1.89 KB
ronald_istos’s picture

ronald_istos CreditAttribution: ronald_istos at roomify - online and open source reservation solutions commented
Issue summary: View changes
BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW Agency for FFW Agency commented
FileSize
services_api_key_auth-http_header_api_key-2715419-4.patch2 KB
interdiff-2715419-1-4.txt2.36 KB
  1. Get value from $_REQUEST for GET and POST method because this superglobal variable contains data from $_POST, $_GET and $_COOKIE (http://php.net/manual/en/reserved.variables.request.php).
  2. Fix coding standards issues in previous patch.

Why not X-Api-Key? See https://tools.ietf.org/html/rfc6648

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW Agency for FFW Agency commented
FileSize
services_api_key_auth-http_header_api_key-2715419-5.patch2.04 KB
interdiff-2715419-4-5.txt1.75 KB
  1. Used more developers-oriented description and naming.
  2. Use two types of API key sources: request and header.
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Needs work

Looks fine to me, but it would help to explain that GET and POST values are both in REQUEST. Please put examples of these in the description.

Not sure I'll have time to test this myself, but will commit once someone else does (and it's RTBC).

BR0kEN’s picture

BR0kEN
Primary language Ukrainian
CreditAttribution: BR0kEN as a volunteer and at FFW Agency for FFW Agency commented
Status: Needs work » Needs review
FileSize
services_api_key_auth-http_header_api_key-2715419-7.patch2.41 KB
interdiff-2715419-5-7.txt1.01 KB
gaydamaka’s picture

gaydamaka CreditAttribution: gaydamaka as a volunteer and at FFW Agency commented
Status: Needs review » Reviewed & tested by the community

Work fine for me.

  • colan committed 24ccec0 on 7.x-1.x authored by ronald_istos 
    Issue #2715419 by BR0kEN, ronald_istos, colan: Provide alternate...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Reviewed & tested by the community » Fixed

Thanks. I improved the English a little bit.

  • colan committed ca2a83b on 7.x-1.x 
    Issue #2715419 by colan: Removed stuff from t() that's getting encoded...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Just gave credit to BR0kEN too as it's now possible to credit more than one person.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Related issues: +#2855138: The API_KEY in http header is not work