Missing data_table for Group and GroupContent

> this (rather poorly documented) table to the annotations.

Is there an issue to improve the documentation of this? (I did notice that this module's entities didn't have a 2nd table, but as I don't fully understand it myself, I didn't say anything. Sorry!)

Nicely spotted and thanks for this great effort!

It seems to work well for me. But I will wait for one of the core developers to set it to RTBC I guess :).

A couple of questions:

1. Am I correct in thinking on a new install, with the 'translatable' annotation and the data table key in place the update_hook / migration is 'redundant' since there is nothing to migrate and the tables should be installed correctly?

If so maybe we can alter the documentation of the update hook a bit to make that more clear.

2. Regarding the examples, I found one over here https://www.drupal.org/node/2641828#comment-10711058 especially the interdiff could be useful: https://www.drupal.org/files/issues/choice-entity-type-2641828-5-interdi...

1. +++ b/group.install
   @@ -47,3 +49,77 @@ function group_update_8001(&$sandbox) {
   +      // At this point the database structure should match what is defined in
   +      // code. However, Drupal still thinks we are running the old schema
   +      // version because it cached the old definitions in the key/value storage.
   +      //
   +      // Inform Drupal of the new schema version.
   +      $schema_repository->setLastInstalledDefinition($entity_type);
   

   One problem with that is that this potentially ignores other update functions which want to deal with the same schema. The alternative would be to just set the new entity tables + translatable flag

2. +++ b/group.install
   @@ -47,3 +49,77 @@ function group_update_8001(&$sandbox) {
   +        // @todo Looks like table mapping can't read $temp_table.
   +        $temp_cols = $storage->getTableMapping()->getAllColumns($temp_table);
   +        $base_cols = $storage->getTableMapping()->getAllColumns($base_table);
   +        $data_cols = $storage->getTableMapping()->getAllColumns($data_table);
   +
   

   You need to pass the new $entity_type to the getTableMapping method, so you get the latest code one, not the last installed version.

First of all, we are rebuilding the entity type's tables from scratch and from code, so I don't see why we need to load the previous schema definition and adjust it instead of simply overwriting it. After all, any module that wanted to adjust the schema also had to adjust the entity type's definition and we are using the latest copy of that in our update hook.

Well, let's assume a user updates from moduleA_8000 to moduleA_8002 and moduleB_8001 to moduleB__8009, while hitting update.php. Update.php will not guarantee you the order of those update functions, so other update functions might come before or after. On the other hand the code version doesn't change during that process, so the definition in code, is up to date already. update.php is tricy.

Secondly, I couldn't for the life of me find a way to retrieve the old storage definition to pass into getTableMapping().

I think it is something like:

$repo = \Drupal::service('entity.last_installed_schema.repository');
$fieldstorage_definitions = $repo->getLastInstalledFieldStorageDefinitions($entity_type_id);
$table_mapping = ... ->getTableMapping($fieldstorage_definitions);

Hello Kristiaan

Applied the patch. I got the attached error when running update.php, and my views are all broken.

I get this when clicking on your flurb then selecting a group:

http://dev-mobilized.pantheonsite.io/group/20

The website encountered an unexpected error. Please try again later.

Drupal\Core\Database\DatabaseExceptionWrapper: Exception in Group actions[group_actions]: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'unknown' in 'order clause': SELECT 'group_actions:block_2' AS view_name, MIN(group_content.id) AS group_content_id FROM {group_content} group_content GROUP BY view_name ORDER BY unknown ASC; Array ( ) in Drupal\views\Plugin\views\query\Sql->execute() (line 1452 of core/modules/views/src/Plugin/views/query/Sql.php).
Drupal\views\ViewExecutable->execute(NULL) (Line: 1412)
Drupal\views\ViewExecutable->render() (Line: 117)
Drupal\views\Plugin\views\display\Block->execute() (Line: 1587)
Drupal\views\ViewExecutable->executeDisplay('block_2', Array) (Line: 78)
Drupal\views\Element\View::preRenderViewElement(Array) (Line: 42)
Drupal\views\Plugin\Block\ViewsBlock->build() (Line: 202)
Drupal\block\BlockViewBuilder::preRender(Array)
call_user_func('Drupal\block\BlockViewBuilder::preRender', Array) (Line: 381)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 448)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 462)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 104)
__TwigTemplate_2617f4b4428068cdd24e54b3cdcc7ae84d6ae2f3e1366ac6b01a2537a9c32694->doDisplay(Array, Array) (Line: 381)
Twig_Template->displayWithErrorHandling(Array, Array) (Line: 355)
Twig_Template->display(Array) (Line: 366)
Twig_Template->render(Array) (Line: 64)
twig_render_template('core/themes/bartik/templates/page.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('page', Array) (Line: 435)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 462)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 88)
__TwigTemplate_039606928b737abc794de14b5f41a97b59176f66c9dcc0bb3b6df3a09ecc43a2->doDisplay(Array, Array) (Line: 381)
Twig_Template->displayWithErrorHandling(Array, Array) (Line: 355)
Twig_Template->display(Array) (Line: 366)
Twig_Template->render(Array) (Line: 64)
twig_render_template('core/themes/classy/templates/layout/html.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('html', Array) (Line: 435)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 195)
Drupal\Core\Render\Renderer->render(Array) (Line: 147)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 148)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 62)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 98)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 77)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 628)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Even your modules's own view - group/x - is expected to crash?

Kristiaan was right re #14. There was a block in the sidebar using a view that was crashing; not the main Group view. Changing the appearance setting to another theme temporarily turns off such blocks and allows you to do the stuff in #16. Then you can reinstate your blocks by reverting the theme.

Thanks for taking the time to do #16.

I have had all sorts of problems since doing this.

My status report says

Entity/field definitions

Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.
Group entity
The Group entity entity type needs to be updated.
The Default translation field needs to be uninstalled.
Group content entity
The Group content entity entity type needs to be updated.
The Default translation field needs to be uninstalled.

Running drush entity-updates gets...

The following updates are pending:

group entity type :
The Group entity entity type needs to be updated.
The Default translation field needs to be uninstalled.
group_content entity type :
The Group content entity entity type needs to be updated.
The Default translation field needs to be uninstalled.
Do you wish to run all pending updates? (y/n): y

...then the error:

Drupal\Core\Entity\EntityStorageException: The SQL storage cannot change the schema for an existing entity type (group) with data. in
Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->onEntityTypeUpdate()
(line 303 of /srv/bindings/96df09bfe929475f9e54ce28f76f5177/code/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php).
Failed: Drupal\Core\Entity\EntityStorageException: !message in Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->onEntityTypeUpdate()
(line 303 of /srv/bindings/96df09bfe929475f9e54ce28f76f5177/code/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php).

Hello Kristiaan
drush entity-updates was the last report after trying the usual things like update.php with no luck.

I restored from a backup. I ran update.php again and deleted every view named in the error message (see image in comment #12) as causing a taxonomy_index_tid error - until all errors were gone and I could get update.php to complete. Then I recreated the deleted views.