After upgrading to 7.x-2.10 I ran a drush fl and noticed several features were marked as "Needs Review". However, I can confirm that I did not change anything to these features before or after upgrading to 7.x-2.10. Should I update these features? Is this normal?

Comments

Steve Polito Design created an issue. See original summary.

achap’s picture

Can confirm that upgrading to 2.10 made most features with needs review but I didn't touch any feature itself. They all say this.


'foreign keys' => array(
  'format' => array(
    'columns' => array(
      'format' => 'format',
    ),
    'table' => 'filter_format',
  ),

),

I fixed it by updating all features using drush fua -y. Nothing appeared to break. However I also want to know if this was intended.

achap’s picture

Just to add some extra information. I upgraded one site from features 7.x-2.7 to 7.x-2.10 and another from 7.x-2.3 to 7.x-2.10. Only the one that was upgraded from 2.3 to 2.10 had the problem with features being in need of review. It's likely that the site that was at 7.x-2.7 also had the problem but as I'm not the only dev here I don't know. So likely the problem was caused somewhere between release 7.x-2.3 and 7.x-2.7 and people are only now realising because 2.10 is a security update.

Steve Polito Design’s picture

@andrew.chappell I also upgraded from 7.x-2.3 to 7.x-2.10. You're probably correct in saying

So likely the problem was caused somewhere between release 7.x-2.3 and 7.x-2.7 and people are only now realising because 2.10 is a security update.
mpotter’s picture

Status: Active » Fixed

Yes, this is normal. The 'foreign keys' stuff was added by a Drupal core change (forget which one). In recent versions of Features we ignore this key when doing exports to prevent features from being marked as overridden when they aren't. Since Features doesn't really know the cause for this change, it marks features as "Needs Review" vs "Overridden" This is essentially saying that if you re-export your Feature it will change (the 'foreign keys' stuff will be removed), but it's not a true "Override" in that the user hasn't changed anything via the UI.

So, as mentioned in #2, the solution is to update your feature export, although I don't normally recommend using the "all" command. You should only update the specific features marked as Needs Review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.