wim.leers at wimleers-acquia in ~/Work/drupal-unus/modules/refreshless on 8.x-1.x*
$ eslint js

/Users/wim.leers/Work/drupal-unus/modules/refreshless/js/refreshless.js
    1:1    error    Definition for rule 'keyword-spacing' was not found                   keyword-spacing
   30:5    error    Split 'var' declarations into multiple statements                     one-var
   31:35   error    Strings must use singlequote                                          quotes
   37:12   error    Closing curly brace appears on the same line as the subsequent block  brace-style
   43:3    warning  JSDoc syntax error                                                    valid-jsdoc
  100:35   error    Missing space before function parentheses                             space-before-function-paren
  103:37   error    Missing space before function parentheses                             space-before-function-paren
  106:35   error    Missing space before function parentheses                             space-before-function-paren
  110:3    error    Expected line before comment                                          lines-around-comment
  110:3    warning  Use @return instead                                                   valid-jsdoc
  116:44   error    Missing space before function parentheses                             space-before-function-paren
  123:31   error    Missing space before function parentheses                             space-before-function-paren
  126:29   error    Missing space before function parentheses                             space-before-function-paren
  129:26   error    Missing space before function parentheses                             space-before-function-paren
  131:5    error    The '__proto__' property is deprecated                                no-proto
  134:27   error    Missing space before function parentheses                             space-before-function-paren
  154:51   error    Expected '!==' and instead saw '!='                                   eqeqeq
  160:142  error    Missing semicolon                                                     semi
  162:7    error    Unexpected console statement                                          no-console
  165:7    error    Unexpected console statement                                          no-console
  167:5    error    Unexpected console statement                                          no-console
  169:7    error    Unexpected console statement                                          no-console
  222:22   error    Missing semicolon                                                     semi
  295:124  error    Missing semicolon                                                     semi
  298:169  error    Missing semicolon                                                     semi
  338:12   error    Expected '===' and instead saw '=='                                   eqeqeq
  347:3    warning  Missing JSDoc parameter description for 'regionName'                  valid-jsdoc
  347:3    warning  Missing JSDoc return description                                      valid-jsdoc
  347:3    warning  Use @return instead                                                   valid-jsdoc
  362:82   error    Missing space before function parentheses                             space-before-function-paren
  372:59   error    Missing semicolon                                                     semi
  391:147  error    Missing semicolon                                                     semi
  399:31   error    Missing space before function parentheses                             space-before-function-paren
  414:5    error    Unexpected console statement                                          no-console
  435:3    warning  Missing JSDoc @return for function                                    valid-jsdoc
  459:71   error    Missing semicolon                                                     semi

✖ 36 problems (30 errors, 6 warnings)

CommentFileSizeAuthor
#2 2713767-2.patch8.99 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Status: Active » Needs review
FileSize
8.99 KB
Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community
+++ b/js/refreshless.js
@@ -87,7 +88,26 @@
+    if (arguments.length === 1) {
+      var object = arguments[0];
+      Object.keys(object).forEach(function (key) {
+        this[key] = object[key];
+      }, this);
+      return;
+    }

@@ -97,41 +117,40 @@
   };
-  State.fromId = function(id) {
-    var state = JSON.parse(storage.getItem(id));
-    state.__proto__ = State.prototype;
-    return state;
+  State.fromId = function (id) {
+    return new State(JSON.parse(storage.getItem(id)));
   };

This conversion was extremely tricky.

  • Wim Leers committed 68aa42f on 8.x-1.x
    Issue #2713767 by Wim Leers: Fix all eslint errors
    
Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.