The facet add form can be much simpler to improve site builder UX. I suggest following changes:

  • Move weight and url_alias to the display tab
  • Auto fill name using js with the selected field name.
  • Change field order (source => field => name)
  • Some small copy changes in the facet add form (field names & description)

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

Status: Needs review » Needs work

The last submitted patch, 2: clean_up_facet_add_form-2712505-2.patch, failed testing.

The last submitted patch, 2: clean_up_facet_add_form-2712505-2.patch, failed testing.

borisson_’s picture

This makes the form look a lot better, such awesome. Tests still fail though.

borisson_’s picture

Component: Code » User interface

Changing component.

StryKaizer’s picture

Forgot core_search_facet tests (lets move those in the same group as facets, so I dont need 2 testgroups to check).
Now with those fixed too.

borisson_’s picture

@StryKaizer: created an issue for that over at #2712519: Change the @group annotation for core search tests. If tests are green, I'm really happy with this patch.

borisson_’s picture

Status: Needs review » Fixed

Fixed a small coding style thing on commit in the .js file, overall very happy with the changes. Thank you very much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.