Place block should also allow to filter by category

Ha! This is exactly the same use case that brought me looking to see if there is already an issue for this.

Working on it ...

hmm ... I guess a single text box that searches both would be better. Doing that now.

I think this is better.

Combining it looks way better!

+++ b/core/modules/block/js/block.admin.js
@@ -49,8 +52,15 @@
           var $row = $label.parent().parent();
...
+            var $category = $label.parent().parent().find('div.block-filter-category-source');

I think this could be
var $category = $row.find('.block-filter-category-source');

The new div around the category is causing some overly-specific tests to fail.
For example:
\Drupal\block\Tests\Views\DisplayBlockTest::testBlockCategory
$pattern = '//tr[.//td[text()=:category] and .//td//a[contains(@href, :href)]]';

Thanks Tim.

Verified the interdiff.txt. It implements all the comments mentioned in #13.
+1 to RTBC.

Re-rolled for 9.2

Verified and tested patch#24. Patch applied successfully.

Testing Steps:
1. Go to Admin > Structure > Block Layout
2. Click on "Place block" button
3. Search block by category. For ex. core
4. Check no result is found
5. Now apply the patch
6. Again, click on "Place block" button
7. Search block by "block name"
8. Verify correct result is displayed
9. Search block by "block category"
10. Verify correct result is displayed
11. Search block by both "block name and category"
12. Verify correct result is displayed

Testing Results:
Block are searched and filtered correctly based on name, category and both

Before patch:

After patch:
Filter by name

Filter by category

Filter by both

+++ b/core/modules/block/js/block.admin.js
@@ -18,8 +18,15 @@
-          var textMatch = $label.text().toLowerCase().indexOf(query) !== -1;
-          $row.toggle(textMatch);
+          var labelMatch = $label.text().toLowerCase().indexOf(query) !== -1;
+          var categoryMatch = false;
+
+          if (!labelMatch) {
+            var $category = $row.find('div.block-filter-category-source');
+            categoryMatch = $category.text().toLowerCase().indexOf(query) !== -1;
+          }
+
+          $row.toggle(labelMatch || categoryMatch);
         }

As it says at the top of this file:

DO NOT EDIT THIS FILE

You have to edit the block.admin.es6.js file and then compile this one.

@tim.plunkett , I have updated the patch as per your inputs. The patch include changes to .es6.js and .js files.

Please review.

Can't use const and then reassign it like that.
I'm not sure that let categoryMatch = false; is the best way to do this, but at least it's valid JS...

Just taking a quick look at the code without actually testing, some other ways you could keep categoryMatch as a const:

const categoryMatch = (() => {
  if(labelMatch) {
    return false;
  }
        
  const $category = $row.find('div.block-filter-category-source');
  return $category.text().toLowerCase().indexOf(query) !== -1;
})();

// or
const $category = $row.find('div.block-filter-category-source');
const categoryMatch = labelMatch ? false : $category.text().toLowerCase().indexOf(query) !== -1;

// or
const categoryMatch = labelMatch ? false : $row.find('div.block-filter-category-source').text().toLowerCase().indexOf(query) !== -1;

Patch not applying in drupal-9.3.x-dev
giving error while applying the patch

Had to adjust based on #3239509: Add String.includes polyfill to support IE11 and Opera Mini.

This is still tagged needs issue summary update, can someone work on that?

Here's an MR of the latest patch.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.