I used a lot colorbox module, but lack of responsive handling force me to switch to photoswipe module :) But one feature I'm missing - set different image style for first image. I made a patch based on colorbox implementation.

Comments

parisek created an issue. See original summary.

parisek’s picture

parisek’s picture

StatusFileSize
new2.93 KB
parisek’s picture

StatusFileSize
new2.91 KB

Removed debug code

parisek’s picture

Status: Active » Needs review

  • ParisLiakos committed 359c5ac on 7.x-2.x authored by parisek
    Issue #2711625 by parisek: Set different image style for first image
    

ParisLiakos’s picture

Status: Needs review » Fixed

thank you!

ParisLiakos’s picture

Version: 7.x-2.x-dev » 8.x-1.x-dev
Assigned: parisek » Unassigned
Status: Fixed » Patch (to be ported)

ah

ollie222’s picture

Just a quick comment to say thank you for this in 7.x-2.dev, it's a fantastically useful feature to have.

Anonymous’s picture

Anonymous’s picture

Attempt at porting the D7 patch to D8. Works nicely for me. Please review!

chucksimply’s picture

#11 worked for me in D8, although breaks if the second image option is set to Hide(do not display image).

m.abdulqader’s picture

#11 worked in D8.

thomas.frobieter’s picture

+1 for this. This was a very usefull Colorbox formatter feature.

anybody’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

#11 makes a lot of sense and seems clean to me. @ChuckSimply can you please explain how it breaks with hide set? What's the expected vs. result?

I can't see a reason in code. The theme function doesn't even know about "hide".

anybody’s picture

Just a little addition for #11: A check if isset($variables['delta']) should be added, otherwise we get a php notice if delta doesn't exist.

anybody’s picture

Corrected patch attached. I think we can leave this RTBC because only the isset was added and the patch is very short.

anybody’s picture

We're using this in production on several sites and it works great. A really helpful feature making this module even more powerful.

Can we get this into the dev branch, sun? What do you think? As you can see it's in 7.x since a long period of time already and would make 8.x even more complete.

anybody’s picture

@sun: Is there a possibility to get this into the next beta5?

anybody’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.6 KB

Rerolled the patch against latest dev. Please review and RTBC. No code changes, simple reroll.

thomas.frobieter’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and works as expected.

anybody’s picture

PLANNED for the next dev and stable release.

  • Anybody committed 2a54aac on 8.x-1.x
    Issue #2711625 by parisek, Anybody, italiatina, thomas.frobieter,...
anybody’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.