I'm importing an Office365 ical feed with repeating events that have many exclusion dates, and only the first 3 exclusion dates per event are imported.

Example RRULE and EXDATE:

RRULE:FREQ=WEEKLY;UNTIL=20161020T100000Z;INTERVAL=2;BYDAY=TU,TH;WKST=MO
EXDATE;TZID=GMT Standard Time:20160322T110000,20160405T110000,20160419T1100
 00,20160421T110000,20160503T110000,20160505T110000,20160517T110000,2016080
 9T110000,20160811T110000

In the ical feed the lines break after 75 characters so the EXDATE array is on several lines. I have downloaded the ics file and removed the linebreaks but importing this file does not work, the events are still only showing 3 exclusion dates.

Eg. Removed linebreaks

RRULE:FREQ=WEEKLY;UNTIL=20161020T100000Z;INTERVAL=2;BYDAY=TU,TH;WKST=MO
EXDATE;TZID=GMT Standard Time:20160322T110000,20160405T110000,20160419T110000,20160421T110000,20160503T110000,20160505T110000,20160517T110000,20160809T110000,20160811T110000

I can edit and manually add more than 3 exclusion dates to an event fine, this is only on import via Feeds.

I'm using Feeds 7.x-2.0-beta2, Date iCal 7.x-3.8, and Date 7.x-2.9

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alangallery created an issue. See original summary.

coredumperror’s picture

Hmm, that's definitely odd that even manually removing the linebreaks doesn't fix this. I recently dealt with a similar issue relating to iCalcreator (the library date_ical uses to parse iCal feeds) not being able to parse multi-line RRULE entries, and based on my fix for that, I would have expected the linebreak removal method you used to work.

I'll see about adding a workaround for EXDATEs as well (I should probably extend it to all the repeat properties). Maybe that will work.

coredumperror’s picture

Turns out that fix I did for RRULEs does seem to remedy the problem for EXDATEs as well. Foolish of me not to have applied this fix to all the repeat properties right from the start, really.

Here's a patch that should fix this for you. Please let me know if it works, so I can incorporate it into the next dev release.

coredumperror’s picture

Status: Active » Needs review
alangallery’s picture

Thanks coredumperror!

I applied the patch to latest dev of Date iCal and now all the exclusion dates are imported (without removal of line breaks). Much appreciated!

Performing the same modification to libraries/ParserVcalendar.inc in Date iCal 7.x-3.8 also seems to work.

coredumperror’s picture

Status: Needs review » Fixed

Excellent! I'll go ahead and push out Date iCal 7.x-3.9, since there have been several significant (though esoteric) bugs fixed since 3.8 came out.

  • coredumperror committed a47407f on 7.x-3.x
    Issue #2710961: Long lists of Exclusion Dates now parse properly on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.