Currently the entity_translation_overview() page callback does all the heavy lifting of generating the table on the translation overview, and at the very end the rendered table rows are passed to the theme_entity_translation_overview() theme function.

This is not very useful, all data is already rendered before it is passed to the theme function, and we don't have any data available about the entity for which the overview is generated. We should move all the rendering logic for the overview inside the theme function.

CommentFileSizeAuthor
#2 2710879-2.patch2.76 KBpfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen as a volunteer commented
Status: Active » Needs review
FileSize
2710879-2.patch2.76 KB

In this patch the logic to render the overview is moved into a theme function so it can be properly overridden. Because there already was a (barely working) theme function available I opted to create a new theme function to not break backwards compatibility.