Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emma.maria created an issue. See original summary.

kostyashupenko’s picture

Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

Assigned: kostyashupenko » Unassigned
Status: Active » Needs review
FileSize
13.71 KB
12.36 KB
480 bytes

Patch here. Changes below

width 768px
after-patch-768.png

width 320px
after-patch-320.png

Manjit.Singh’s picture

Status: Needs review » Needs work
FileSize
112.03 KB

This is not working for me when sidebar/toolbar is opened. Please check the screenshot.

email

Anyone else facing the same issue ?

kostyashupenko’s picture

@Manjit.Singh, screen in the description of task - is a Bartik theme, but your screen comes from Seven theme. But yea, i can confirm your bug for Seven. Do i need to solve this issue here in this task?

Manjit.Singh’s picture

oopppsss :( completely forget that where i was checking.

And yeah we can solve this issue for seven, but we have to create another issue for it. Because This is Bartik specific issue.

emma.maria’s picture

Title: Email field on node edit causes horizontal scrollbar » "input type='text'" fields within table markup cause horizontal scrollbars on node add/edit
Status: Needs work » Needs review

This is a Bartik issue. We can no longer put fixes for both Bartik and Seven in the Classy theme so we need separate issues.

emma.maria’s picture

Status: Needs review » Needs work
+++ b/core/themes/bartik/css/components/table.css
@@ -56,6 +56,11 @@ tr th {
+  tr td input {

This selector is too specific, it affects all input elements. We only want to target the text and email input fields within "field-multiple-table" component.

emma.maria’s picture

Title: "input type='text'" fields within table markup cause horizontal scrollbars on node add/edit » Bartik & Seven : "input type='text'" fields within table markup cause horizontal scrollbars on node add/edit
Component: Bartik theme » CSS
Issue tags: +Seven

Regarding #7 I change my mind. As it's a small fix I'm moving this to the CSS component and specifying it's a fix for both Core themes.

imalabya’s picture

FileSize
1.02 KB
962 bytes

Added a patch which targets only "text" and "email" field.
For Seven theme, the width had to be adjusted for iPads(768px)

imalabya’s picture

Status: Needs work » Needs review

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

djsagar’s picture

Status: Needs review » Needs work

Nee work for 8.9.x-dev.

djsagar’s picture

Status: Needs work » Needs review
FileSize
54.48 KB
65.84 KB
1.42 KB

Creating patch for 8.9.x-dev.

Please review.

Thanks!

Madhu kumar’s picture

Applied patch #20 cleanly and fields within the table markup are working as expected.

RTBC

radheymkumar’s picture

Applied patch #20 success
Thanks

bnjmnm’s picture

FileSize
104.93 KB

Removing credit for #22.

  • There's no reason to provide screenshots of something that already appeared in a prior comment
  • It's especially unhelpful when it's not even a new screenshot, but a cropped version of the one added previously. Aside from everything being pixel-identical --- it's extraordinarily unlikely the two of you commenting here would have their aggregated CSS file be named with the same randomly generated hash

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

Applied #20 patch in drupal-9.3.x-dev
Successfully applied and looks good for me

For ref sharing screenshot ............

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Manibharathi E R’s picture

Patch #20 Applied success fully on Drupal 9.4.x.

Steps to Reproduce:
1. Install Drupal Instance
2. Create One plain text with Multiple Allowed Values
3. Add new content in the Mobile view
4. Click on the Manage Button. You can able to reproduce the issue.

gaurav-mathur’s picture

Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

Assigned: gaurav-mathur » Unassigned
FileSize
8.51 KB
16.51 KB

Patch #20 successfully applied and looks good for me.

mherchel’s picture

Project: Drupal core » Seven
Version: 9.4.x-dev » 1.0.0-alpha1
Component: CSS » Code

Moving this over to the Seven project, as it's no longer in Drupal core.