CommentFileSizeAuthor
#3 2709993-3.patch28.09 KBh3rj4n
#3 interdiff.txt3.78 KBh3rj4n
#2 2709993-2.patch25.83 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
25.83 KB
h3rj4n’s picture

FileSize
3.78 KB
28.09 KB

The big change I didn't expect is that all the @file tags at the top of the files are removed. I guess I missed when this was removed overall.

With the last commit a couple of @file tags where back. I removed this and changed some documentation that wasn't accurate.

alexpott’s picture

@h3rj4n yeah the @file thing is a new standard. tldr; in PSR0/4 code an @file docblock is pointless... a single class per file. Put docs in the class docblock.

  • h3rj4n committed fe55e72 on 8.x-1.x authored by alexpott
    Issue #2709993 by h3rj4n, alexpott: Run phpcs fixer on the codebase and...
h3rj4n’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.