Why complain about missing sites/default/settings.php in multi-site? [#2709727]

Even if environment settings are injected, create a stub settings.php file for compatibility.

For a multi-site installation I don't see the use of having a sites/default/settings.php ... I can create an empty one to satisfy this module ... but that sounds backward.

Comments

Comment #1

20 April 2016 at 07:18

helmo created an issue. See original summary.

Comment #2

24 April 2016 at 01:59

FluxSauce committed f28f3a8 on 7.x-1.x

Issue #2709727: Allow missing settings.php for multi-site configurations...

Comment #3

FluxSauce CreditAttribution: FluxSauce at Four Kitchens commented 24 April 2016 at 02:02

Assigned:	Unassigned	» FluxSauce
Status:	Active	» Fixed

That's fair! While a case could be made for having a default site configured, it's not that strong, so it now deals with that situation gracefully. Resolved.

jon@Decker ~/projects/drupal/sites/drupal-7-multisite.local (7.x) $ drush abp --detail
Best practices: 100%
  No action required.                                                                                    [success]
  Multi-site: Detect multi-site configurations.
    The following multi-site configuration(s) were detected: drupal-7-multisite.local
  sites/default/settings.php: Check if the configuration file exists.
    settings.php does not exist, but this is a multi-site configuration.
  sites/default: Check if it exists and isn't symbolic
    sites/default is a directory and not a symbolic link.
  sites/all: Check if it exists and isn't symbolic
    sites/all is a directory and not a symbolic link.
  Superfluous files in /sites: Detect unnecessary files.
    No unnecessary files detected.
  Fast 404 pages: Check if enabled.
    Fast 404 pages are enabled.
  PHP Filter: Check if enabled.
    PHP Filter is not enabled.

Also fixed a bug with missing fail message for a legitimately missing settings.php.