CDN UI depends on config module because off Url::fromRoute('config.import_single')->toString(TRUE)->getGeneratedUrl() in CdnSettingsForm.php:144

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

Wim Leers’s picture

Thanks, great catch! I think it'd be better to not depend on the config module though, and just let it link to the appropriate documentation on d.o instead.

(Because if you have the Config module enabled, chances are you'll use configuration directly, and not the CDN UI module.)

Thoughts?

Wim Leers’s picture

Component: Origin Pull mode » User interface

.

chr.fritsch’s picture

Linking to the docs is the better solution. Having as less as possible dependencies is always good.

Wim Leers’s picture

Title: cdn_ui depends on config module » cdn_ui should not link to a config module route, but link to the d.o handbooks
Category: Bug report » Task
Priority: Normal » Minor
Status: Needs review » Needs work
Issue tags: +Novice, +php-novice

Indeed!

So this would then need to link to https://www.drupal.org/documentation/administer/config. There's no more specific documentation page than that one. Care to roll a patch?

Vinay15’s picture

Assigned: Unassigned » Vinay15

Hi Wim,

Can you suggest me where should I add this link?

Wim Leers’s picture

#6: the IS already describes where :)

Vinay15’s picture

Status: Needs work » Needs review
FileSize
1.22 KB

Thanks!! I should have read the IS properly. Anyways, I have tried to add the link.

Wim Leers’s picture

Status: Needs review » Needs work

Rather than adding a new link, just update the existing link. :)

Vinay15’s picture

Status: Needs work » Needs review
FileSize
1.02 KB
1.13 KB

Tried updating the patch.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Perfect, thanks! :)

  • Wim Leers committed ef9335e on 8.x-3.x authored by Vinay15
    Issue #2709003 by Vinay15, chr.fritsch: cdn_ui should not link to a...
Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.