Follow-up to #2693569: RefreshLess should declare a dependency on Drupal 8.1

Please add a composer.json to this project.

CommentFileSizeAuthor
#9 missing-comma-2708579-9.patch403 bytesDevin Carlson
#6 refreshless-add_composer_json-2708579-6.patch976 bytesheddn
#5 refreshless-add_composer_json-2708579-5.patch968 bytesheddn
#4 refreshless-add_composer_json-2708579-4.patch1.28 KBheddn
#2 refreshless-add_composer_json-2708579-2.patch965 bytesheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Issue summary: View changes
Status: Active » Needs review
FileSize
refreshless-add_composer_json-2708579-2.patch965 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Needs work 
  1. +++ b/composer.json
@@ -0,0 +1,27 @@
+  "homepage": "https://www.drupal.org/project/big_pipe",

    Wrong URL. 

  2. +++ b/composer.json
@@ -0,0 +1,27 @@
+    "drupal/core": "~8.1"

    :)

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs work » Needs review
FileSize
refreshless-add_composer_json-2708579-4.patch1.28 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
FileSize
refreshless-add_composer_json-2708579-5.patch968 bytes

There's the right patch.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
FileSize
refreshless-add_composer_json-2708579-6.patch976 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Fixed

Thanks!

  • Wim Leers committed b7962c6 on 8.x-1.x authored by heddn 
    Issue #2708579 by heddn, Wim Leers: Add composer.json
Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Fixed » Needs review
FileSize
missing-comma-2708579-9.patch403 bytes

Composer Manager is throwing a Could not decode JSON: Syntax error error. :)

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

I probably should have run composer validate before posting the patch. It would have saved some issues.

$ composer validate --strict
./composer.json is valid
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Reviewed & tested by the community

I've opened https://www.drupal.org/node/2708751 to see if we can get that added to the test bots.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Fixed

Woah, nice catch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.