Problem/Motivation

The mailchimp.info file from Drupal 7 times, is still present in 8.x-1.x.

Proposed resolution

There is no use for it anymore. So, simply remove it.

CommentFileSizeAuthor
#5 remove_unused_info-2708569-3.patch0 bytespankajsachdeva
#2 mailchimp-remove_d7s_info_file-2708569-2.patch449 bytesszeidler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

szeidler created an issue. See original summary.

szeidler’s picture

szeidler CreditAttribution: szeidler at Ramsalt Lab commented
Status: Active » Needs review
FileSize
mailchimp-remove_d7s_info_file-2708569-2.patch449 bytes

Here's the patch.

pankajsachdeva’s picture

pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at QED42 commented

Deleted Drupal 7 .info file instead of removing lines from the file as done in the above patch.

pankajsachdeva’s picture

pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at QED42 commented
pankajsachdeva’s picture

pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at QED42 commented
FileSize
remove_unused_info-2708569-3.patch0 bytes
szeidler’s picture

szeidler CreditAttribution: szeidler at Ramsalt Lab commented

Patch #2 leads to the file deletion. You attached a 0 byte patch. Anyhow, for the maintainer it will be even more simple.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Needs review » Reviewed & tested by the community

I 've successfully applied patch #2 and looks good to me. That's why RTBC'ed!

  • amyvs committed 0295721 on 8.x-1.x 
    Issue #2708569 by szeidler, pankajsachdeva, asrob: Remove unused .info...
amytswan’s picture

amytswan CreditAttribution: amytswan at ThinkShout commented
Status: Reviewed & tested by the community » Fixed

Thanks for catching that, @szeidler!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.