As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MurthyVittala created an issue. See original summary.

MurthyVittala’s picture

this patch has the js errors cleaned.

Neelanjana Das’s picture

Status: Active » Needs review

  • jurgenhaas committed cc29d02 on 8.x-1.x
    Issue #2708377 by MurthyVittala: Browser refresh nodeJS integration
    
jurgenhaas’s picture

Thanks @MurthyVittala for pointing this out. I have taken the opportunity to add a few more comments to that js file to make sure that ESLint stops complaining completely. Please review in the dev release and let me know what you think.

Note: I had ignored the coding standard before because that JS file would never be included in any Drupal file but would only be used by a nodeJs application, but standard compliance sill makes sense. So thanks for the heads-up.

jurgenhaas’s picture

Status: Needs review » Closed (fixed)

Included in release 8.x-1.1