As this SafeMarkup::checkPlain going to be deprecated this is now replaced with Html::escape().
Please find the patch attached.

CommentFileSizeAuthor
#7 feeds-2708359-7.patch9.57 KBneerajsingh
feeds-safemarkup.patch9.19 KBpashupathi nath gajawada
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pashupathi Nath Gajawada created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, feeds-safemarkup.patch, failed testing.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Status: Needs work » Needs review
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Needs work

I think you forgot to specify the namespace of the Html class in these files. Anyway, tests are failing and the branch tests are passing now, so the "Needs work" status is correct here.

Note: it would also be useful to verify if escaping is still needed at all.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Assigned: pashupathi nath gajawada » rajeshwari10
Issue tags: -Quickfix +Quickfix Need Reroll
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented

Patch at the issue summary doesn't apply..

$ git apply --index ../patches/feeds-safemarkup.patch
error: patch failed: src/Controller/FeedController.php:7
error: src/Controller/FeedController.php: patch does not apply
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented
Status: Needs work » Needs review
FileSize
feeds-2708359-7.patch9.57 KB

Adding a new patch here...

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Assigned: rajeshwari10 » Unassigned
twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented

Looks fine to me.

  • twistor committed 6f00932 on 8.x-3.x authored by neerajsingh 
    Issue #2708359 by pashupathi nath gajawada, neerajsingh, rajeshwari10,...
twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Status: Needs review » Fixed

Removed an invalid use statement in "src/Entity/Subscription.php" as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Valuebound commented