Comments

droplet created an issue. See original summary.

Wim Leers’s picture

Issue tags: +needs backport to D7

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

aerozeppelin’s picture

Initial patch.

Status: Needs review » Needs work

The last submitted patch, 5: testonly-2707933-5-fail.patch, failed testing.

cilefen’s picture

Title: drupalSettings.path.currentPath in frontpage should returns "" » drupalSettings.path.currentPath in frontpage should return ""
Issue summary: View changes
cilefen’s picture

Title: drupalSettings.path.currentPath in frontpage should return "" » drupalSettings.path.currentPath on frontpage should return ""
dawehner’s picture

+++ b/core/modules/system/system.module
@@ -695,7 +695,7 @@ function system_js_settings_alter(&$settings, AttachedAssetsInterface $assets) {
+    'currentPath' => \Drupal::service('path.matcher')->isFrontPage() ? '' : $current_path,
...
     'isFront' => \Drupal::service('path.matcher')->isFrontPage(),

Note: We could store the path.matcher in a variable

aerozeppelin’s picture

Status: Needs work » Needs review
FileSize
1.13 KB
2.47 KB

Changes as per #9.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This looks great for me

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2707933-10.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sudhanshug’s picture

The patch no longer could be applied to 8.4.x
I re-rolled the patch to apply cleanly to the latest version.

sudhanshug’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: currentpath-2707933-14.patch, failed testing.

sudhanshug’s picture

Status: Needs work » Needs review

In #14, it shows that the patch passes the tests. But in #16, I don't how it is saying that the patch failed testing.
It may be jenkins bug.
Changing the status back to 'needs review'