Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Rework 'View the archive' (admin/config/smsframework/sms_track/view) and user's 'My Message view' (/user/{user}/my-messages), as a builtin view of SMS message entities.
Merge builtin view to an 'optional' config. these configs activate when required modules are installed. see views.view.user_admin_people.yml.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | sms_track____user_relationship_and_sort.png | 118.03 KB | dpi |
Comments
Comment #2
dpiI'm thinking to only include the global view. Leaving out the 'My messages' view. It was an issue that users can see confirmation code in the my message view despite not being confirmed yet. Also, was the 'my message' view actually useful?
Comment #3
almaudoh CreditAttribution: almaudoh commentedI think we should leave in the my messages view. It has been useful in some cases I have used. We can add an option to disable archiving for specific messages (e.g. the message with confirmation code).
Comment #4
dpiMessages arnt categorized... We have no way to find these kinds of messages.
Comment #5
almaudoh CreditAttribution: almaudoh commentedWe could have a
SmsMessage::setNotArchivable()method which the entity checks before saving, and default it tofalse.Comment #6
dpiNo matter what, the message is added to the queue. There is no concept of not-archiving. Everything is 'archived', and then deleted based on an expiration timer.
If we dont 'archive', then the message isnt sent.
Comment #7
almaudoh CreditAttribution: almaudoh commentedYeah. Hmmmm....
Comment #8
dpiWe could make the view visible only to administrators... Or instead it may be worth adding an exposed form on the global message list which allows the admin to filter down recipient entities.
Comment #9
dpiActually we cant add it to _the_ global list because the relationship is entity specific. But we can have another global list which features only sms messages of a particular entity type. For example just for 'users':
Comment #10
dpiFeature addition, no API modification or schema change.
Feature not required for 1.0, but nice to have.