Don't let error throw blocks other scripts execution.

CommentFileSizeAuthor
#16 Screenshot 2020-09-29 at 3.52.42 PM.png53.48 KBnishantghetiya
#14 interdiff_11-14.txt3.21 KBraman.b
#14 2707669-14.patch3 KBraman.b
#12 Screen Shot 2020-09-10 at 1.36.56 PM.png399.64 KBtanubansal
#11 2707669-11.patch2.88 KBsharma.amitt16
drupal-thorowError.patch1.38 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Needs work

Needs patch reroll

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

sharma.amitt16’s picture

sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2707669-11.patch2.88 KB

Rerolled the patch for 9.1.x.

tanubansal’s picture

tanubansal CreditAttribution: tanubansal at Salsa Digital commented
FileSize
Screen Shot 2020-09-10 at 1.36.56 PM.png399.64 KB

Tested #11, changes are visible
This can be moved to RTBC

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Smile commented
Status: Needs review » Needs work

When modifying js files, it's the .es6.js files that needs to be updated, see https://www.drupal.org/docs/frontend-developer-tools-for-drupal-core

Also the reroll changes code that is generated by babel, which is not expected

raman.b’s picture

raman.b CreditAttribution: raman.b at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
2707669-14.patch3 KB
interdiff_11-14.txt3.21 KB

Made required changes, resolved formatting issues and compiled ajax.es6.js to ajax.js

nishantghetiya’s picture

nishantghetiya CreditAttribution: nishantghetiya at QED42 for Drupal India Association commented
Assigned: Unassigned » nishantghetiya
nishantghetiya’s picture

nishantghetiya CreditAttribution: nishantghetiya at QED42 for Drupal India Association commented
Assigned: nishantghetiya » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot 2020-09-29 at 3.52.42 PM.png53.48 KB

Patch applied successfully and also satisfy #13 changes.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs work

I have read through the issue and see that this is tagged as needing manual testing but not testing has been done. I also find the IS too vague. Does this problem exists in other files or just the ones changed in the patch?

Setting to NW for, at least, the manual testing.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Title: Replace `throw` statement `Drupal.throwError` » Wrap errors with `Drupal.throwError`
Issue tags: +Needs issue summary update, +Needs steps to reproduce, +ContributionWeekend2022

The issue summary isn't clear and there are no steps to reproduce the issue so tagging.

I'm unclear if this is a bug or just a task. If I understand correctly, the issue summary says this blocks execution for other scripts. If this is the case, IMO this is a bug.

Nitpick: When reviewing the code, I see there is an inconsistency between formatting where some are "nicely" formatted and others are inline. It would be nice to be consistent. Examples:

  1. +++ b/core/misc/ajax.es6.js
@@ -232,8 +232,10 @@
+      Drupal.throwError(
+        new Error(
+          'Drupal.ajax() function must be called with one configuration object only',
+        ),

  2. +++ b/core/misc/ajax.js
@@ -110,7 +110,7 @@ function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len
+      Drupal.throwError(new Error('Drupal.ajax() function must be called with one configuration object only'));

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.