I've seen that the module is not cleaning the classes and uses a complete string instead of adding them as an array.

Added patch with Html::cleanCssIdentifier on each class and add them as an array.

CommentFileSizeAuthor
#9 After.png10.61 KBrenatog
#9 Before.png11.11 KBrenatog
#4 clean_unvalid_classes-2706511-4.patch792 bytesalzz
#2 clean_unvalid_classes-2706511-2.patch783 bytesalzz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alzz created an issue. See original summary.

alzz’s picture

alzz CreditAttribution: alzz at Metadrop commented
FileSize
clean_unvalid_classes-2706511-2.patch783 bytes

Attaching patch!

Thanks for porting the module to D8, missing it so much!

alzz’s picture

alzz CreditAttribution: alzz at Metadrop commented
Status: Active » Needs review

Oops! changing to needs review

alzz’s picture

alzz CreditAttribution: alzz at Metadrop commented
FileSize
clean_unvalid_classes-2706511-4.patch792 bytes

Modified patch to not sanitize underscore into hyphen as version 7 does.

CRZDEV’s picture

CRZDEV CreditAttribution: CRZDEV at Metadrop commented

Last patch works fine (#4), working the same way as drupal 7 module.

Thanks!

ScottLozier’s picture

ScottLozier CreditAttribution: ScottLozier as a volunteer commented

Confirming #4 is working as expected.

neha.gangwar’s picture

neha.gangwar CreditAttribution: neha.gangwar as a volunteer commented
Title: Clean unvalid classes » Cleanup invalid classes

Changed the title for better understanding.

neha.gangwar’s picture

neha.gangwar CreditAttribution: neha.gangwar as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Patch #4 works cleanly.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Issue tags: +ciandt-contrib
FileSize
Before.png11.11 KB
After.png10.61 KB

Hi people.

I applied the patch #4 and works good for me.

Before:

After:

Thank you very much.

Good Work.

Regards.

  • RenatoG committed aeaeca1 on 8.x-1.x authored by alzz 
    Issue #2706511 by alzz, RenatoG, neha.gangwar, ScottLozier, CRZDEV:...
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Committed to the dev branch.

Thank you very much for contribution people.

Good Work.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.