As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 7 problems (7 errors, 0 warnings)

CommentFileSizeAuthor
#2 commerce-zuora-eslinterror-2.patch1.06 KBkpoornima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kpoornima created an issue. See original summary.

kpoornima’s picture

kpoornima CreditAttribution: kpoornima as a volunteer and at Melity commented
Status: Active » Needs review
FileSize
commerce-zuora-eslinterror-2.patch1.06 KB

this patch has the cleaned up code.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
Status: Needs review » Closed (won't fix)
Issue tags: -JavaScript clean-up

This isn't for D8.

Neelanjana Das’s picture

Neelanjana Das CreditAttribution: Neelanjana Das at Melity commented

It can be applied to d7 also as it is according to coding standards. the code doesnot make any big changes. it is just a clean up.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented

Then you should also run code review for all files, not just JS.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Title: Commerce Zuora ESLint Errors » Commerce Zuora coding standards
Status: Closed (won't fix) » Needs work