Hi @duozersk,
Are you working on D8 port of this module? If not, I am interested in porting this module to D8 version.

Comments

NarendraR created an issue. See original summary.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
CreditAttribution: duozersk as a volunteer commented
Issue tags: -needs Drupal 8 port

Narendra,

Thank you for using the module and for the feature request.

Nope, I'm not working on the D8 version currently, feel free to create and submit one, I will open the 8.x-1.x branch and commit your code if it is good and working.

Thanks
AndyB

narendraR’s picture

narendraR
He/Him
Primary language English
Location Jaipur, India
CreditAttribution: narendraR commented
Assigned: Unassigned » narendraR

Hi @duozersk,

Thanks for the update. I will work on D8 port and will update you when completed.

narendraR’s picture

narendraR
He/Him
Primary language English
Location Jaipur, India
CreditAttribution: narendraR commented
Assigned: narendraR » Unassigned
Status: Active » Needs review

Hi AndyB,

I have created a sandbox project.
https://www.drupal.org/sandbox/narendra23/2714889
Please review.

Thanks,
Narendra

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
CreditAttribution: duozersk as a volunteer commented
Status: Needs review » Needs work

Narendra,

It looks awesome, thank you for the porting.

I have one question - doesn't D8 support placing external libraries into some libraries directory? I don't like this file http://cgit.drupalcode.org/sandbox-Narendra23-2714889/tree/js/addtocopy_... to be included with the module.

And one note - could you please fix this comment http://cgit.drupalcode.org/sandbox-Narendra23-2714889/tree/js/addtocopy.... - the "jsTestBlueWeight" is smth not related to this module.

And then please create a patch. Or I can grab your code and commit it into the 8.x-1.x branch if you want.

I would also kindly ask you to become a co-maintainer of this D8 version.

Thanks
AndyB

narendraR’s picture

narendraR
He/Him
Primary language English
Location Jaipur, India
CreditAttribution: narendraR commented

Hi AndyB,

Thanks for your valuable suggestions.

For point 1, my thought was to provide users with a module which does not require external library and use same library in drupal 8 style. In external library we need to depend on that URL, if it is up and running or not. Please suggest.
We can use following code in libraries.yml for external library

addtocopy.external:
  remote: http://tops.net.ua/jquery_addtocopy
  version: 1.2
  js:
    http://andrewberezovsky.ru/demo/download/addtocopy.js: { type: external, minified: false }

Point 2: Fixed

Regarding D8 branch, please create a branch and make me co-maintainer.

Thanks,
Narendra

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
CreditAttribution: duozersk at FFW commented
Status: Needs work » Fixed

Narendra,

I have added you as a co-maintainer and committed your sandbox repository to the 8.x-1.x branch.

As for the library, I will create another issue against the 8.x-1.x branch.

Thanks
AndyB

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
CreditAttribution: duozersk at FFW commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
narendraR’s picture

narendraR
He/Him
Primary language English
Location Jaipur, India
CreditAttribution: narendraR commented

Hi AndyB,

Thanks for your support and making me maintainer.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.