Hi.

I've seen that to send user id attribute the user id is sent using a hash in order to don't show info which can identify the user.
Could the code of hash generation be moved to a function?

This function can be used by modules which depends of google_analytics for their own features.

Attached a patch which moves the code to a function.

Can you review this? Thanks!

CommentFileSizeAuthor
#9 google_analytics-user-id-function-9.patch1.43 KBomarlopesino
#6 google_analytics-user-id-function-6.patch1.38 KBomarlopesino
#5 google_analytics-user-id-function-5.patch1.38 KBomarlopesino
#2 google_analytics-user-id-function-2.patch1.37 KBomarlopesino
google_analytics-user-id-function-1.patch1.88 KBomarlopesino
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mistermoper created an issue. See original summary.

omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
FileSize
google_analytics-user-id-function-2.patch1.37 KB

Attach new patch discarding changed made by module download.

omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
Status: Active » Needs review
omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
Issue summary: View changes
omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
FileSize
google_analytics-user-id-function-5.patch1.38 KB

Update patch adding coding style.

omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
FileSize
google_analytics-user-id-function-6.patch1.38 KB
hass’s picture

hass CreditAttribution: hass commented
Version: 7.x-2.x-dev » 8.x-2.x-dev

Ok, but this requires a D8 patch first.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work
omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
FileSize
google_analytics-user-id-function-9.patch1.43 KB

Attached new patch for drupal 8.

omarlopesino’s picture

omarlopesino
he/him
CreditAttribution: omarlopesino at Metadrop commented
Status: Needs work » Needs review

  • hass committed 5e4b863 on 8.x-2.x authored by mistermoper 
    Issue #2705565 by mistermoper: User id feature: move user hash...

  • hass committed 4b443a8 on 7.x-2.x authored by mistermoper 
    Issue #2705565 by mistermoper: User id feature: move user hash...
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

Many thanks for this clean patch and code style. Happens too rare :-).

hass’s picture

hass CreditAttribution: hass commented
Issue tags: +piwik

Committed to Piwik, too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.