Improve activity titles

This is a key question that will result to many different answers depending on the evolution of both collect (configurability) and activity (pluggability).

1) Initially, we want to know about a fast coded approach. It makes sense that the code could provide a property that is a concatenated thing for the two cases:
- entity capture will display: "Entity " $entity_type [+ $bundle] + $title
- mail capture will display: "Mail " $subject // No From, To!
This will be persisted as activity label.

Note that with advanced configurability, these processed properties could be created through the UI. This is not a high priority now.

2) Activity will get pluggable and instead of the label, the activity view will display a summary. The collect container activity plugin will then be able to ship a more specific summary with more rich data such as Mail From + To and more.

At this stage, we will be able to make the activity look nice with the different summaries. Some first UX love will be spent to make the different summaries intuitive.

3) We want to have better type information in the activity. It should not be "Collect container". Instead it should be "Mail" or "Entity" and then this information can be removed from the label / summary.

Once we have this all don, Activity is pretty mature.
We will be able to split this all into multiple issues.

Failing tests = Needs work.

+++ b/crm/src/Plugin/collect/Processor/ActivityCreator.php
+++ b/crm/src/Plugin/collect/Processor/ActivityCreator.php
@@ -72,7 +72,28 @@ class ActivityCreator extends ProcessorBase {

@@ -72,7 +72,28 @@ class ActivityCreator extends ProcessorBase {
-        $title = $data->get($title_property);
+        // Check for default title property provided by a model plugin.
+        if ($title_property == CollectDataInterface::DEFAULT_TITLE_KEY) {
... (and many more)

The processing setting should simply point to the property _default_title and you will get it here as $title_property.
No changes needed here.

You just need to provide the static property with ModelPluginInterface:: getStaticPropertyDefinitions() and then intercept on resolveQueryPath() to provide the _default_title value.

1. +++ b/src/Model/ModelPluginBase.php
   @@ -14,6 +14,7 @@ use Drupal\collect\TypedData\CollectDataInterface;
   @@ -105,7 +106,13 @@ abstract class ModelPluginBase extends PluginBase implements ModelPluginInterfac
   
   @@ -105,7 +106,13 @@ abstract class ModelPluginBase extends PluginBase implements ModelPluginInterfac
      public static function getStaticPropertyDefinitions() {
   ...
   +      '_default_title' => new PropertyDefinition('_default_title', $default_title_data_definition),
   

   I'm a bit confused, instead of defining the title property just for the two mentioned models such as Inmail and Collect, you extend the Model interface and put many things into the Base. In fact that doubles the complexity.
   (The issue was not about introducing a title for all Collect containers. We should decide about generalisation at a later point IMHO.)

2. +++ b/src/Plugin/collect/Model/CollectJson.php
   @@ -292,4 +292,51 @@ class CollectJson extends Json implements DynamicModelTypedDataInterface, Contai
   +    if ($property_name == CollectDataInterface::DEFAULT_TITLE_KEY) {
   
   +++ b/src/TypedData/CollectDataInterface.php
   @@ -19,6 +19,13 @@ interface CollectDataInterface extends ComplexDataInterface {
   +  const DEFAULT_TITLE_KEY = '_default_title';
   

   Please simply use the strings.

3. +++ b/src/Plugin/collect/Model/CollectJson.php
   @@ -292,4 +292,51 @@ class CollectJson extends Json implements DynamicModelTypedDataInterface, Contai
   +          return $this->t('@entity_type @bundle', ['@entity_type' => $entity_type, '@bundle' => $bundle]);
   ...
   +        return $this->t('@entity_type', ['@entity_type' => $entity_type]);
   

   No t() for simple placeholders.

4. +++ b/src/Plugin/collect/Model/CollectJson.php
   @@ -292,4 +292,51 @@ class CollectJson extends Json implements DynamicModelTypedDataInterface, Contai
   +        $this->logger->warning($e->getMessage());
   

   When does this happen? Comment?

5. +++ b/src/Plugin/collect/Model/FieldDefinition.php
   @@ -177,6 +177,29 @@ class FieldDefinition extends Json implements SpecializedDisplayModelPluginInter
   +  public static function getDefinitionContainerTypedData(CollectContainerInterface $values_container) {
   

   This code is outsourced. Call it from the origin. If i remember right it contained some more error handling that is needed. I think the method should throw an exception if it fails..

Yeah, right direction. We're getting to the point. :-)

1. +++ b/src/Model/ModelPluginBase.php
   @@ -153,4 +153,11 @@ abstract class ModelPluginBase extends PluginBase implements ModelPluginInterfac
   +  public function getDefaultTitle(CollectDataInterface $data) {
   
   +++ b/src/Model/ModelPluginInterface.php
   @@ -115,4 +115,17 @@ interface ModelPluginInterface extends PluginInspectionInterface {
   +  public function getDefaultTitle(CollectDataInterface $data);
   

   Then this need to die also. No Interface or Base changes. All on specific model levels.

2. +++ b/src/Plugin/collect/Model/CollectJson.php
   @@ -217,25 +218,21 @@ class CollectJson extends Json implements DynamicModelTypedDataInterface, Contai
        if (isset($values_data['fields'])) {
   ...
   +        $field_definition_data = FieldDefinition::getDefinitionContainerTypedData($collect_container);
   

   Note here that Typed data definition is not necessarily a container, although we switched to that.
   Field definition could be attached as part of the value container.

   The helper API should cover both cases and return TypedData. If there is a definition Container or direct definition is an internal problem.

3. +++ b/src/Plugin/collect/Model/CollectJson.php
   @@ -292,4 +289,64 @@ class CollectJson extends Json implements DynamicModelTypedDataInterface, Contai
   +      if ($collect_data) {
   

   Move this check into getDefaultTitle().
   And then the @todo default title case will disappear.

Also the default config for collect_demo needs an update (select default_title as CollectJson processing for activity matcher) and be properly asserted in demo test.

As discussed a minimum invasive POC attached, will not work. ;-)

Looks pretty good. One major thing.

+++ b/src/Plugin/collect/Model/CollectJson.php
@@ -173,12 +184,46 @@ class CollectJson extends Json implements DynamicModelTypedDataInterface, Contai
+      return $default_title;

The original label/title is wrongly dropped from the default_title... It's nor just entity type + bundle.

Reviewed and committed.