Converting the NodeOrderManager to a service with an interface will allow other modules to extend the NodeOrderManager via its service.

I will be uploading a patch shortly. Hopefully we can start pushing the module to an RC. I can upload a roadmap after this ticket is resolved.

BTW, my client, MSKCC, has (via Phase2) and is going to now continue sponsoring development on this module.

Notes

  • Refactoring it going to be the base minimum.
  • More tests need to be written before major code reworking
CommentFileSizeAuthor
#13 convert-nodeordermanager-to-a-service-with-an-interface-2704691-12.patch22.87 KBjrockowitz
#8 convert-nodeordermanager-to-a-service-with-an-interface-2704691-08.patch18.25 KBjrockowitz
#7 convert-nodeordermanager-to-a-service-with-an-interface-2704691-07.patch18.25 KBjrockowitz
#6 convert-nodeordermanager-to-a-service-with-an-interface-2704691-06.patch18.25 KBjrockowitz
#3 convert-nodeordermanager-to-a-service-with-an-interface-2704691-03.patch18.24 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Issue summary: View changes
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
FileSize
convert-nodeordermanager-to-a-service-with-an-interface-2704691-03.patch18.24 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Assigned: jrockowitz » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: convert-nodeordermanager-to-a-service-with-an-interface-2704691-03.patch, failed testing.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
FileSize
convert-nodeordermanager-to-a-service-with-an-interface-2704691-06.patch18.25 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
FileSize
convert-nodeordermanager-to-a-service-with-an-interface-2704691-07.patch18.25 KB

Arg....my best guess is comment #6's patch did not get tested because of issue with D.O. earlier today. So let's try it again.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
FileSize
convert-nodeordermanager-to-a-service-with-an-interface-2704691-08.patch18.25 KB

One more last attempt where I upload the patch without previewing it.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Issue summary: View changes
dieuwe’s picture

dieuwe
Location Auckland, NZ
CreditAttribution: dieuwe at Sparks Interactive commented

I've added you as a maintainer so that you can commit patches to the D8 branch and create releases when you are ready.

I'm too busy to stay on top of this right now, so have fun :)

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented

@Dieuwe Thank you for adding me as a maintainer.

I completely understand that you are busy. I will post a D8 RC roadmap ticket and then start pushing things forward.

Since I can't get the tests to run on D.O. I will do a little more testing locally and then commit this patch.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Status: Needs work » Needs review
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
FileSize
convert-nodeordermanager-to-a-service-with-an-interface-2704691-12.patch22.87 KB

New to patching contrib modules and realized that the NodeOrderManagerInterface and nodeorder.services.yml were not being included in the patch.

And I finally realized that the issue status needs to be set to 'Needs Review' for automated tests to be executed.

The last submitted patch, 6: convert-nodeordermanager-to-a-service-with-an-interface-2704691-06.patch, failed testing.

The last submitted patch, 7: convert-nodeordermanager-to-a-service-with-an-interface-2704691-07.patch, failed testing.

The last submitted patch, 8: convert-nodeordermanager-to-a-service-with-an-interface-2704691-08.patch, failed testing.

  • jrockowitz committed 8b2afef on 8.x-1.x 
    Issue #2704691 by jrockowitz: Convert NodeOrderManager to a Service with...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Status: Needs review » Fixed

All tests are passing and I am using the patch on a production website.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.