Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I've had to update the lazysizes library, as the v1.1.3-RC1 wasn't working properly for me.
I was surprised to see the js libraries being shipped as part of the module. I think most Drupal developers now are used to the flow of adding external JS dependencies into their libraries folder.
So I was a bit confused as to how I actually update the lazysizes library, I came across this #2352599: Decouple external libraries from Picture module by using Libraries module? which suggests there is now an option to include your own version. However, I am unable to work out how this is supposed to work.
Currently I have:
1) Gone to admin/config/media/picture/settings and set Picture polyfill to use" to Use custom polyfill
2) Added in my own libraries into my sites default libraries location
3) Cleared caches, refreshed page etc, now no libraries are being included.
Upon investigating in picture_library(), nothing here is implemented in when the picture_polyfill_version variable is set to own.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | picture-add_libraries_support-2704487-6.patch | 10.15 KB | Chris Burge |
| #3 | picture-add_libraries_support-2704487-3.patch | 10.16 KB | Chris Burge |
| #2 | option_to_include_own-2704487-2.patch | 4.6 KB | Leon Kessler |
Comments
Comment #2
Leon Kessler CreditAttribution: Leon Kessler commentedCould we not check if the path exists in the libraries folder, and if not default back to what comes with the Picture module?
Patch attached.
Comment #3
Chris Burge CreditAttribution: Chris Burge commented@Leon Kessler - You are correct. The "own" settings has absolutely no affect. I'm changing this to a feature request because, to this point, nothing has been implemented.
The attached patch takes a different approach by utilizing the Libraries module.
Comment #4
Chris Burge CreditAttribution: Chris Burge commentedI've given this more thought. I think it would be better to add Libraries support in a new branch. I've reopened a relevant issue: #2352599: Decouple external libraries from Picture module by using Libraries module?. It's my hope that the related issue gets some attention and we can close this issue as a duplicate.
Comment #5
attiks CreditAttribution: attiks at Attiks commentedI somehow missed this, the idea of "Use your own version" is to include whatever you want (or nothing at all). I propose we solve this in #2352599: Decouple external libraries from Picture module by using Libraries module? and leave this as it is for the current major version.
Comment #6
Chris Burge CreditAttribution: Chris Burge commentedPath to ls.aspectratio.js was incorrect in #3. Updated patch corrects.
Comment #7
lesleyfernandes CreditAttribution: lesleyfernandes commentedWe will solve this on #2352599: Decouple external libraries from Picture module by using Libraries module?