When using Swiftmailer on a website with configuration in GIT, it is convenient to make configuration overrides on development servers using the configuration override API.

However, src/Plugin/Mail/SwiftMailer.php loads configuration in a way that blocks configuration overrides.

Can we change this to default behaviour? See patch.

CommentFileSizeAuthor
#2 swiftmailer-configuration-2703833-1-8.x-1.x.patch864 bytesbjaxelsen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bjaxelsen created an issue. See original summary.

bjaxelsen’s picture

bjaxelsen CreditAttribution: bjaxelsen commented
FileSize
swiftmailer-configuration-2703833-1-8.x-1.x.patch864 bytes
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented

I think the config object does not implement ArrayAccess, you have to change the other code as well.

bjaxelsen’s picture

bjaxelsen CreditAttribution: bjaxelsen commented

@webflo where do we need ArrayAccess? As far as I know the only difference between Config::getRawData and Config::get is that the latter allows overrides. Does this cause some restrictions on the configuration object? I have the proposed patch running on a production site right now without problems.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented

@bjaxelsen: Sorry, you are right. I thought get returns an config object, buts its an array.

  • webflo committed d4e0367 on 8.x-1.x authored by bjaxelsen 
    Issue #2703833 by bjaxelsen: Allow configuration overrides
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Active » Fixed

Committed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.