Thanks for this marvelous module. It works suberbly on my config other than I receive a warning when I attempt to use remote url (just after hitting submit):

Warning: Parameter 1 to _filefield_source_remote_parse_header() expected to be a reference, value given in filefield_source_remote_value() (line 147 of /usr/share/nginx/html/drupal/sites/all/modules/filefield_sources/sources/remote.inc).

[update] the image still always successfully transfers. I'm running drupal7.43/php5.6/hhvm3.13/nginx1.8/mariadb/ubuntu14.04.

CommentFileSizeAuthor
#9 filefield_sources-remove-curl-reference.patch636 bytesquicksketch
#5 2703405-5.patch732 bytesheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pribeh created an issue. See original summary.

pribeh’s picture

pribeh CreditAttribution: pribeh commented

I believe this may be the related php error log.

[error] 13074#0: *292 open() "/usr/share/nginx/html/drupal/file/ajax/field_image/und/form-vS0o7UKbvVd6IKZfr3kx8az5WHZvKUlbEGhSkr8g4js" failed (2: No such file or directory), client: 99.249.126.201, server: domain.com, request: "POST /file/ajax/field_image/und/form-vS0o7UKbvVd6IKZfr3kx8az5WHZvKUlbEGhSkr8g4js HTTP/1.1", host: "domain.com", referrer: "http://domain.com/node/add/article"

pribeh’s picture

pribeh CreditAttribution: pribeh commented
Issue summary: View changes
pribeh’s picture

pribeh CreditAttribution: pribeh commented
Issue summary: View changes
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Active » Needs review
FileSize
2703405-5.patch732 bytes
pribeh’s picture

pribeh CreditAttribution: pribeh commented

@heykarthikwithu, thanks for writing the patch. I applied patch 2703405-5.patch to remote.inc but the warning still shows up for me but now points to line 149 (curl_exec($ch)).

Warning: Parameter 1 to _filefield_source_remote_parse_header() expected to be a reference, value given in filefield_source_remote_value() (line 149 of /usr/share/nginx/html/drupal/sites/all/modules/filefield_sources/sources/remote.inc)

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch as a volunteer and at Lullabot commented

Thanks for this report. I think we can easily fix this just by removing the by-reference operator from _filefield_source_remote_parse_header(). Starting with PHP 5 all objects are always by reference anyway, this is probably some very legacy leftovers. In addition, we don't even modify the cURL handler anyway, so removing the reference operator won't make any difference.

  • quicksketch committed 471d7b7 on 7.x-1.x 
    Issue #2703405: Remove the by-reference operator in cURL callback.
quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch as a volunteer and at Lullabot commented
Status: Needs review » Fixed
FileSize
filefield_sources-remove-curl-reference.patch636 bytes

Committed the attached patch to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.