Follow-up to #2191395: Make dpm() and friends pluggable (with Krumo, Kint, Ladybug etc)

in #2191395: Make dpm() and friends pluggable (with Krumo, Kint, Ladybug etc) was created a pluggable dumper system that allow contrib to extend the devel functionality and provide their own plugins for formatting and displaying the variables debugged through devel functions.

The following implementations of dumper have been created and are currently provided by devel:
- CromePhp
- FirePhp
- DoctrineDebug
- DrupalVariable
- Kint (kint module)

you was also talk of adding implementations for Ladybug and VarDumper.

IMHO devel should provide only the plugins management, plugins that works with libraries which are present in core (DoctrineDebug, DrupalVariable) and a default implementation, all other implementation should live in contrib modules (that means remove the CromePhp and FirePhp implementations).
We should decide before ship a stable release which dumper plugins ship with devel

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx created an issue. See original summary.

willzyx’s picture

Category: Feature request » Task
Status: Reviewed & tested by the community » Postponed
willzyx’s picture

Issue summary: View changes
willzyx’s picture

Status: Postponed » Active
youx’s picture

Hi willzyx,
I am glad you opened a discussion on that topic ;)
Coming from Symfony world, I would give a big +1 for the VarDumper component.
I understand that the library is out of the needs of devel, but it's usability makes it a must-have out of the box.

There is also the question of using the VarDumper with webprofiler module, there has been a discussion opened by lussoluca on that.
IMHO webprofiler is still missing some features like debug() - VarDumper based - profiling and exception stack trace to be even more useful.

By the way, could you tell me how to cleanly require an external library like VarDumper from a module if not in core ?

lussoluca’s picture

youx ,
for vardumper you could try the https://www.drupal.org/project/vardumper module, it has a GIT branch level-integration that provides a plugin for Devel

youx’s picture

Hi Lussoluca,
Thanks for the advice, I will give it a try.
Is there any status or started work for collecting exceptions stack trace in the profiler ?

moshe weitzman’s picture

Version: 8.x-1.x-dev » 8.x-3.x-dev
Assigned: Unassigned » moshe weitzman
Status: Active » Needs review
FileSize
5.72 KB

Attached patch removes FirePHP, ChromePHP, and Drupal Variable (too simplistic).

Should the default by var-dumper, given that its dependency is already in our composer.json? Or maybe Kint becomes default if we move its dependency from suggest to require? Both of these are more capable that Doctrine.

Status: Needs review » Needs work

The last submitted patch, 8: devel-2703347-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

moshe weitzman’s picture

Version: 8.x-3.x-dev » 8.x-1.x-dev
Assigned: moshe weitzman » Unassigned
Status: Needs work » Active
FileSize
5.51 KB

Fixing test

moshe weitzman’s picture

Version: 8.x-1.x-dev » 8.x-3.x-dev
Assigned: Unassigned » moshe weitzman
Status: Active » Needs work
moshe weitzman’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: devel-2703347-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

moshe weitzman’s picture

Status: Needs work » Needs review
FileSize
5.8 KB
lussoluca’s picture

I'd love to see var-dumper as the default dumper in Devel

  • moshe weitzman authored a00dd75 on 8.x-3.x
    Issue #2703347 by moshe weitzman: Decide which dumper plugins ship with...
moshe weitzman’s picture

Status: Needs review » Fixed

OK, I'v merged this. Lets do the change of default in a future issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.