Remove or implement remaining view modes [#2703303]

Problem/Motivation

There are several options in the "Display in entity links" checkbox set that are non-functional. Many of these fields were carried over from Flag 3.x with the intention of implementing them when D8 was stable and Flag core was functioning.

We never got around to that.

Proposed resolution

Get around to that.

Implement remaining view modes, or remove them entirely. Some of this might be transitioned to psudofields and D8 view modes instead of a specific checkbox. Create a test for display modes and link display options.

Remaining tasks

Research which display link options may still be implemented as they were in 3.x, preferring view modes & psudofields where possible.
Create patch.

User interface changes

Options may be added or removed from FlagEditForm.

API changes

Options may be added or removed from the entity and node flag types.

Data model changes

Flag type plugin configuration changes.

Comments

Comment #1

9 April 2016 at 13:07

socketwench created an issue. See original summary.

Comment #2

joachim CreditAttribution: joachim commented 10 April 2016 at 13:12

What does this cover that isn't covered by #2703229: [regression] Flags not appearing in node and comment links section?

Comment #3

socketwench CreditAttribution: socketwench at FFW commented 11 April 2016 at 15:23

Display on RSS view mode
Display on Search index view mode
Display on Search result highlighting input view mode

Comment #4

joachim CreditAttribution: joachim commented 11 April 2016 at 19:47

Do you mean display as a pseudofield, or display in links?

Comment #5

socketwench CreditAttribution: socketwench at FFW commented 11 April 2016 at 20:20

I mean those checkboxes under "Display in entity links".

Comment #6

joachim CreditAttribution: joachim commented 11 April 2016 at 20:33

Ah right. That's part of #2703229: [regression] Flags not appearing in node and comment links section then.

Comment #7

socketwench CreditAttribution: socketwench at FFW commented 11 April 2016 at 20:35

A lot of those checkboxes just seem like artifacts from before Drupal 7. With view modes being a much bigger deal in 8, I keep wondering if we should majorly rethink that entire set of options. I would imagine most would rather use psudofields and view modes in 8.