Problem/Motivation

String as a class name is not allowed in PHP7.

Proposed resolution

Rename to something else, StringFieldHandler?

Possibly rename others as well. Very short meaningless class names like String, Text are considered bad practice and against coding standards.

Also, looks like we have no test for this code at the moment, our php7 tests are passing. Collect tests do cover this and currently fail in PHP 7.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 fatal_error_cannot_use-2703003-2.patch14.33 KBmbovan
#2 fatal_error_cannot_use-2703003-2.patch14.33 KBmbovan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Active » Needs review
FileSize
fatal_error_cannot_use-2703003-2.patch14.33 KB

I'm also getting some errors about String class - with (php5.6 and) php7 installed.

A starting patch.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
FileSize
fatal_error_cannot_use-2703003-2.patch14.33 KB

Reuploading.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented

Created a followup #2704707: Test coverage for field handlers

CTaPByK’s picture

CTaPByK CreditAttribution: CTaPByK at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks ok.

  • slashrsm committed 220c4c1 on 8.x-1.x authored by mbovan 
    Issue #2703003 by mbovan, CTaPByK: Fatal error: Cannot use 'String' as...
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented

Another follow-up: #2704987: [META] Finish incomplete match field handlers

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.