Are there any plans to port this project to Drupal 8?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kepford created an issue. See original summary.

iamEAP’s picture

Hey @kepford,

Given that Google has effectively killed the GSA, the future of this module is kind of up for debate.

I personally have no plans to port this module to Drupal 8, but I recognize that 2018 is a ways away. I imagine there will be sites that use this module in D7 that will be ported to D8 in the meantime...

Happily accepting ports, patches, and co-maintainers.

larowlan’s picture

I plan to work on the port this week

mhavelant’s picture

I have a rudimentary D8 version, and as discussed with @iamEAP I'll push it to the repo (8.x-1.x branch).

mhavelant’s picture

Done. Some vague description of the progress and remaining things can be found in the PORT_STATUS.txt

larowlan’s picture

thanks!

I'm going to continue working on it in https://www.drupal.org/sandbox/larowlan/2884195

larowlan’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
larowlan’s picture

Status: Active » Needs review
FileSize
116.65 KB

Work from today (in patch and sandbox): (commit log: http://cgit.drupalcode.org/sandbox-larowlan-2884195/log/?h=8.x-1.x)

  • fe9fd10 Issue #2702993 by larowlan: Drupal 8 Port - Remove debug - removed a stray dpm from code
  • 3b3f955 Issue #2702993 by larowlan: Drupal 8 Port - use type URL - admin form host was using link, should have been url
  • 4d94a7f Issue #2702993 by larowlan: Drupal 8 Port - admin form test - ported admin form tests
  • a3ce7be Issue #2702993 by larowlan: Drupal 8 Port - phpcbf - coding standards
  • 2106947 Issue #2702993 by larowlan: Drupal 8 Port - fix config/schema - schema/config fixes
  • 14fdd2d Issue #2702993 by larowlan: Drupal 8 Port - add a parser service - moving parsing to service
  • 9118f19 Issue #2702993 by larowlan: Drupal 8 Port - add a parser service
  • e93cb00 Issue #2702993 by larowlan: Drupal 8 Port - search block test - port search block test
  • 6acd706 Issue #2702993 by larowlan: Drupal 8 Port - search block - wrote search block
  • 1228359 Issue #2702993 by larowlan: Drupal 8 Port - base test class - test refactor
  • 401f73f Issue #2702993 by larowlan: Drupal 8 Port - test for search page - search page test
  • 7c984a7 Issue #2702993 by larowlan: Drupal 8 Port - default value in search page - fix for search page
  • 997d565 Issue #2702993 by larowlan: Drupal 8 Port - skeleton results test
  • 00524c5 Issue #2702993 by larowlan: Drupal 8 Port - search results - refactor search service so its testable, test and search results
  • 71e9948 Issue #2702993 by larowlan: Drupal 8 Port - remove dead code

Next steps are the remaining theme templates and other bits like synonyms etc.

With the given structure, can easily write tests for those before they're implemented.

larowlan’s picture

Also, let me know if you're after co-maintainer, happy to push this direct to module.

larowlan’s picture

FileSize
138.95 KB

Today's work

  • 17756f2 Issue #2702993 by larowlan: Drupal 8 Port - update status, cleanup dead code
  • 98a48f2 Issue #2702993 by larowlan: Drupal 8 Port - update status
  • 2b8c417 Issue #2702993 by larowlan: Drupal 8 Port - Synonyms
  • b3bd99c Issue #2702993 by larowlan: Drupal 8 Port - Synonym test
  • 2497c64 Issue #2702993 by larowlan: Drupal 8 Port - Pager
  • f31c811 Issue #2702993 by larowlan: Drupal 8 Port - Output header, sort
  • ac25d99 Issue #2702993 by larowlan: Drupal 8 Port - test for pager, sorting, header
  • 216cb71 Issue #2702993 by larowlan: Drupal 8 Port - refactor names, output title
  • 6e4b8d2 Issue #2702993 by larowlan: Drupal 8 Port - test for search title

Now working with tests:

  • * Settings form
  • * Search page/form
  • * Synonyms
  • * Pager
  • * Sorting
  • * Search block

Not done:

  • * Onebox results output
  • * keymatch output
  • * Spelling suggestion output
  • * Click/JS/Posting click stats
  • * Clustering
  • * Language filtering

I have no immediate need for those in the not done list so don't expect to be working on them for a while.

I'm using this on a site I'm building so would be great if we could merge those commits in from the sandbox:

git remote add larowlan https://git.drupal.org/sandbox/larowlan/2884195.git
git fetch larowlan
git merge larowlan/8.x-1.x
iamEAP’s picture

@larowlan Added VCS access.

  • larowlan committed 00524c5 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - search results
    
  • larowlan committed 005494d on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - Synonyms
    
  • larowlan committed 1228359 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - base test class
    
  • larowlan committed 14fdd2d on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - add a parser service
    
  • larowlan committed 2106947 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - fix config/schema
    
  • larowlan committed 216cb71 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - refactor names, output title
    
  • larowlan committed 3b3f955 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - use type URL
    
  • larowlan committed 401f73f on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - test for search page
    
  • larowlan committed 4d94a7f on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - admin form test
    
  • larowlan committed 6acd706 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - search block
    
  • larowlan committed 6e4b8d2 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - test for search title
    
  • larowlan committed 71e9948 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - remove dead code
    
  • larowlan committed 76980bf on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - update status
    
  • larowlan committed 7c984a7 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - default value in search page
    
  • larowlan committed 8bec0fd on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - Synonym test
    
  • larowlan committed 9118f19 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - add a parser service
    
  • larowlan committed 997d565 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - skeleton results test
    
  • larowlan committed 9f77ae5 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - update status, cleanup dead...
  • larowlan committed a3ce7be on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - phpcbf
    
  • larowlan committed ac25d99 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - test for pager, sorting,...
  • larowlan committed e93cb00 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - search block test
    
  • larowlan committed f14e0ad on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - Pager
    
  • larowlan committed f31c811 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - Output header, sort
    
  • larowlan committed fe9fd10 on 8.x-1.x
    Issue #2702993 by larowlan: Drupal 8 Port - Remove debug
    
larowlan’s picture

Status: Needs review » Fixed

Thanks, committed and closing this

Will add new issues for remaining items in todo list.

larowlan’s picture

Added an alpha release

Added section about d8 to project page.

Removed d6 section (obsolete).

Added project supporting organisations (please add more)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.