While working the issue #2702867: ShareThis added to node content array even if the extra field is set to hidden for the display mode, I encountered that when we enable sharethis for Node Content, sharethis div is being loaded but the js is not being included and hence there are no buttons seen. I don't know whether this case is specific to me only.

CommentFileSizeAuthor
#2 after_enabling-2702979-2.patch486 bytespurushotam.rai
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

purushotam.rai created an issue. See original summary.

purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Active » Needs review
FileSize
after_enabling-2702979-2.patch486 bytes

Status: Needs review » Needs work

The last submitted patch, 2: after_enabling-2702979-2.patch, failed testing.

purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Needs work » Needs review
purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Priority: Normal » Critical
xangy’s picture

xangy
he/him
Primary language Hindi
Location Pune 🇮🇳
CreditAttribution: xangy at QED42 commented
Status: Needs review » Reviewed & tested by the community

I can confirm the issue. If we don't use sharethis_include_js(), the necessary code that are responsible for the display of sharing widgets are not shown. I have tested the patch on simplytest.me and it solved the issue.

  • purushotam.rai committed 48aaf60 on 7.x-2.x 
    Issue #2702979 by purushotam.rai, xangwish: After enabling sharethis for...
purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Reviewed & tested by the community » Fixed

Thanks xangwish for confirmation.

Marking this issue as fixed. Feel free to re-open if issue still persists.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.