In the 7.x-1.x readme file, along with the general site instructions there is no mention that configuration more than likely will require configuration changes to admin/structure/block > specific theme name > modify as appropriate.

This hung me up and took a long time to figure out, you should explicitly mention this as part of the setup process.

CommentFileSizeAuthor
#8 2702935-8-readme-theme-blocks-D8.patch1.02 KBmtift
#7 2702935-readme-theme-blocks-7.patch858 bytesmtift
#7 2702935-7-interdiff.txt696 bytesmtift
#4 2702935-readme-theme-blocks-4.patch785 bytesmtift
#3 2702935-readme-theme-blocks-3.patch1.3 KBmtift
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

holyfire created an issue. See original summary.

holyfire’s picture

holyfire CreditAttribution: holyfire commented
Assigned: holyfire » Unassigned
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Active » Needs review
FileSize
2702935-readme-theme-blocks-3.patch1.3 KB

We do mention the blocks in the Adsense and DoubleClick sections. How about this for the theme config?

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
FileSize
2702935-readme-theme-blocks-4.patch785 bytes

Actually, this patch

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray at Lullabot commented

Maybe add a line?
* Make sure to configure the blocks for the AMP theme you have selected

I know blocks are mentioned elsewhere, but since the original concern was about knowing to set up blocks for a theme, maybe this would help?

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs review » Needs work
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review
FileSize
2702935-7-interdiff.txt696 bytes
2702935-readme-theme-blocks-7.patch858 bytes
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
FileSize
2702935-8-readme-theme-blocks-D8.patch1.02 KB

And a Drupal 8 version, which is pretty much exactly the same as the D7 version

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray at Lullabot commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • mtift committed f77257e on 7.x-1.x 
    Issue #2702935 by mtift: Documentation Update - Blocks Configuration in...
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Reviewed & tested by the community » Fixed

Thanks, Marc. Committed to 7.x-1.x.

  • mtift committed d21436c on 8.x-1.x 
    Issue #2702935 by mtift: Documentation Update - Blocks Configuration in...
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented

Oh, and pushed to 8.x-1.x. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift at Lullabot commented