If using discounts then CNC rule raise error because discount line items don't have commerce_product property. This patch fix this

CommentFileSizeAuthor
#7 2702847-discounts-commerce-node-checkout-7.patch1.38 KBdaggerhart
#6 2702847-discounts-commerce-node-checkout-6.patch1.73 KBSam152
#3 commerce_node_checkout-rules_failing-2702847-7.patch981 bytesinterlated
#2 skip_line_items_without_commerce_product-2702847-1.patch711 bytescosolom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cosolom created an issue. See original summary.

cosolom’s picture

cosolom CreditAttribution: cosolom commented
FileSize
skip_line_items_without_commerce_product-2702847-1.patch711 bytes
interlated’s picture

interlated CreditAttribution: interlated as a volunteer commented
FileSize
commerce_node_checkout-rules_failing-2702847-7.patch981 bytes

I found the same thing. Line item with no products. Probably due to zero shipping items although I have reordered so that 'Delete shipping line items on shopping cart updates' runs after. With Billy Invoice the rule 'on changing status' runs twice anyway.

Very similar patch to the attached one allowed the rule to process the files.

marty.true’s picture

marty.true CreditAttribution: marty.true commented

#2 above worked to publish the node however, the order is still set as "Pending". It needs to fire the other rule that sets to "Complete"

marty.true’s picture

marty.true CreditAttribution: marty.true at X-Static Media Group commented
Status: Active » Needs review
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
FileSize
2702847-discounts-commerce-node-checkout-6.patch1.73 KB

Here is my patch to make this module work with commerce discount. It only factors in line items with the "commerce_product" property set into it's determination if the order status should be completed or not.

daggerhart’s picture

daggerhart CreditAttribution: daggerhart at Hook 42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
2702847-discounts-commerce-node-checkout-7.patch1.38 KB

Patch in #6 fixes the problem, but needs to be re-rolled to remove the full path to the module.

Here is an updated patch.