Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The annotation for ContentTranslationHandler::entityFormTitle
is not documenting the return value.
Proposed resolution
Use the relevant description from \Drupal\Core\Entity\EntityInterface::label(), since this is just a wrapper around that task.
Remaining tasks
Patch coming.
User interface changes
N/A
API changes
N/A
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | missing_return-2701769-2.patch | 733 bytes | snufkin |
Comments
Comment #2
snufkin CreditAttribution: snufkin at Acquia commentedAdding patch.
Comment #4
snufkin CreditAttribution: snufkin at Acquia commentedComment #5
eporama CreditAttribution: eporama as a volunteer and at Acquia commentedThis matches the
@return
value ofDrupal\Core\Entity\EntityInterface::label()
so I agree it should be what we get back.Marking as RTBC.
Comment #6
alexpottAll the other @return docs in this file look correct. Committed aee92c5 and pushed to 8.1.x and 8.2.x. Thanks!
Added missing line on commit.