Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The current embed for instagram is pulling in the embed into an iframe. This method does not allow the iframe to have the proper width and height.
By including instagram's embed js and changing the embed code it allows the instagram embed js to properly set the width and height of the embed.
Our site is responsive and we'd prefer to have the embed js to automatically set the width and height of the embed.
Existing issue
Fixed with embed js
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fix-instagram-embed-issue-2701283-4.patch | 2.05 KB | dodozhang21 |
| #3 | fix-instagram-embed-issue-2701283-1.patch | 2.05 KB | dodozhang21 |
| #2 | fix-instagram-embed-issue-2701283-1.patch | 2.32 KB | dodozhang21 |
Comments
Comment #2
dodozhang21 CreditAttribution: dodozhang21 as a volunteer and commentedHere's the patch for including embed js and updating the theme for instagram.
I know instagram doesn't really follow the standard video embed pattern but would like to know what the maintainer think about this direction. It would allow this module to support more social media embed such as facebook and twitter.
Comment #3
dodozhang21 CreditAttribution: dodozhang21 as a volunteer and commentedUpdated patch with the correct path in the patch.
Comment #4
dodozhang21 CreditAttribution: dodozhang21 as a volunteer and commentedUpdated patch with the correct path in the patch.
Comment #5
sokrplare CreditAttribution: sokrplare commentedTried out the patch and it is working well for me - with Flickr and other non-consistent aspect ratio media formats available, there needs to be some pattern here to allow for dynamic sizing.
Comment #6
dodozhang21 CreditAttribution: dodozhang21 as a volunteer and commentedExisting issue
Fixed with embed js
Comment #7
dodozhang21 CreditAttribution: dodozhang21 as a volunteer and commentedComment #8
sokrplare CreditAttribution: sokrplare commentedMight be pre-mature RTBC here, but this patch applied cleanly and resolved as expected for me. Hopefully can get some other eyes on it at least and then I know fixes/changes will be made fast if needed.
Comment #9
minnur CreditAttribution: minnur at Chapter Three commentedThank you for the patch. I will review it and apply shortly.
Comment #12
minnur CreditAttribution: minnur at Chapter Three commented