[D7] Cureti Phone Login

@crueti,

Can you please fix the following errors,

ILE: /var/www/drupal-7-pareview/pareview_temp/cureti_phone_login.admin.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------
17 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "cureti_phone_login" but found
| | "CURETI_PHONE_LOGIN_MERCHANT_ID"
25 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "cureti_phone_login" but found
| | "CURETI_PHONE_LOGIN_API_KEY"
31 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "cureti_phone_login" but found
| | "CURETI_PHONE_LOGIN_PASSWORD_CHANGE"
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/cureti_phone_login.module
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
33 | WARNING | Open page callback found, please add a comment before the
| | line why there is no access restriction

FILE: .../www/drupal-7-pareview/pareview_temp/includes/curetilogin.connect.inc
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
4 | ERROR | [x] Doc comment short description must end with a full stop
145 | ERROR | [ ] Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/cureti_phone_login.info
---------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" form the info file, it will be added
| | by drupal.org packaging automatically
6 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
17 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
17 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/cureti_phone_login.module
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must end with a full stop
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

Please find the following link
http://pareview.sh/pareview/httpsgitdrupalorgsandboxcureti2696305git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please update the comment block (@param and @return) for all the functions except hooks.

one more thing

Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

Automated Review

Please resolve the coding standard errors http://pareview.sh/pareview/httpsgitdrupalorgsandboxcureti2696305git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style and Other issues

1. Could you please use system_settings_form function instead of you custom cureti_phone_login_admin_form_submit function?
2. It would be nice if you add setting configure = admin/config/people/curetiphonelogin in info file for your module. It will help users to configure your module easier
3. Could you please assign result of variable_get function to a variable and do not call it twice for each setting in cureti_phone_login_admin_form function

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2836590

Project 2: https://www.drupal.org/node/2700889

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.